From 956f68fda4e7c98cf91a770bf8c61f6c8ab82ac9 Mon Sep 17 00:00:00 2001 From: tomokisun Date: Sat, 2 Dec 2023 22:12:29 +0900 Subject: [PATCH 1/2] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20find=20friend?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- Packages/GodPackage/Package.swift | 9 ++++++++- .../FindFriend.swift | 0 .../Sources/FindFriendFeature/Localizable.xcstrings | 5 +++++ Packages/GodPackage/Sources/OnboardFeature/Onboard.swift | 1 + 4 files changed, 14 insertions(+), 1 deletion(-) rename Packages/GodPackage/Sources/{OnboardFeature => FindFriendFeature}/FindFriend.swift (100%) create mode 100644 Packages/GodPackage/Sources/FindFriendFeature/Localizable.xcstrings diff --git a/Packages/GodPackage/Package.swift b/Packages/GodPackage/Package.swift index c5bf93fe..a0cdb4ce 100644 --- a/Packages/GodPackage/Package.swift +++ b/Packages/GodPackage/Package.swift @@ -19,6 +19,7 @@ let package = Package( .library(name: "CupertinoMessageFeature", targets: ["CupertinoMessageFeature"]), .library(name: "DeleteAccountFeature", targets: ["DeleteAccountFeature"]), .library(name: "EmailFeature", targets: ["EmailFeature"]), + .library(name: "FindFriendFeature", targets: ["FindFriendFeature"]), .library(name: "FindLocationFeature", targets: ["FindLocationFeature"]), .library(name: "ForceUpdateFeature", targets: ["ForceUpdateFeature"]), .library(name: "FriendRequestFeature", targets: ["FriendRequestFeature"]), @@ -132,6 +133,12 @@ let package = Package( .product(name: "UIPasteboardClient", package: "CupertinoPackage"), .product(name: "ComposableArchitecture", package: "swift-composable-architecture"), ]), + .target(name: "FindFriendFeature", dependencies: [ + .product(name: "Styleguide", package: "UIComponentPackage"), + .product(name: "ContactsClient", package: "CupertinoPackage"), + .product(name: "AnalyticsClient", package: "DependencyPackage"), + .product(name: "ComposableArchitecture", package: "swift-composable-architecture"), + ]), .target(name: "FindLocationFeature", dependencies: [ .product(name: "Styleguide", package: "UIComponentPackage"), .product(name: "AnalyticsClient", package: "DependencyPackage"), @@ -235,6 +242,7 @@ let package = Package( "TutorialFeature", ]), .target(name: "OnboardFeature", dependencies: [ + "FindFriendFeature", "ProfileStoryFeature", "InviteFriendFeature", "SchoolSettingFeature", @@ -245,7 +253,6 @@ let package = Package( .product(name: "ProfileImage", package: "UIComponentPackage"), .product(name: "ActivityView", package: "UIComponentPackage"), .product(name: "StringHelpers", package: "DependencyPackage"), - .product(name: "ContactsClient", package: "CupertinoPackage"), .product(name: "ShareLinkClient", package: "DependencyPackage"), .product(name: "ShareLinkBuilder", package: "DependencyPackage"), .product(name: "UIPasteboardClient", package: "CupertinoPackage"), diff --git a/Packages/GodPackage/Sources/OnboardFeature/FindFriend.swift b/Packages/GodPackage/Sources/FindFriendFeature/FindFriend.swift similarity index 100% rename from Packages/GodPackage/Sources/OnboardFeature/FindFriend.swift rename to Packages/GodPackage/Sources/FindFriendFeature/FindFriend.swift diff --git a/Packages/GodPackage/Sources/FindFriendFeature/Localizable.xcstrings b/Packages/GodPackage/Sources/FindFriendFeature/Localizable.xcstrings new file mode 100644 index 00000000..8a470103 --- /dev/null +++ b/Packages/GodPackage/Sources/FindFriendFeature/Localizable.xcstrings @@ -0,0 +1,5 @@ +{ + "sourceLanguage" : "en", + "strings" : {}, + "version" : "1.0" +} diff --git a/Packages/GodPackage/Sources/OnboardFeature/Onboard.swift b/Packages/GodPackage/Sources/OnboardFeature/Onboard.swift index a1bbc17c..519eb26b 100644 --- a/Packages/GodPackage/Sources/OnboardFeature/Onboard.swift +++ b/Packages/GodPackage/Sources/OnboardFeature/Onboard.swift @@ -1,4 +1,5 @@ import ComposableArchitecture +import FindFriendFeature import Contacts import ContactsClient import FirebaseAuth From 016a1209af38295d9b80eb0456892ca4653b2b62 Mon Sep 17 00:00:00 2001 From: tomokisun Date: Sat, 2 Dec 2023 22:16:42 +0900 Subject: [PATCH 2/2] =?UTF-8?q?feat:=20=F0=9F=8E=B8=20localize?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../FindFriendFeature/Localizable.xcstrings | 35 +++++++++++++++++-- .../OnboardFeature/Localizable.xcstrings | 30 ---------------- 2 files changed, 33 insertions(+), 32 deletions(-) diff --git a/Packages/GodPackage/Sources/FindFriendFeature/Localizable.xcstrings b/Packages/GodPackage/Sources/FindFriendFeature/Localizable.xcstrings index 8a470103..f327b614 100644 --- a/Packages/GodPackage/Sources/FindFriendFeature/Localizable.xcstrings +++ b/Packages/GodPackage/Sources/FindFriendFeature/Localizable.xcstrings @@ -1,5 +1,36 @@ { "sourceLanguage" : "en", - "strings" : {}, + "strings" : { + "Find My Friends" : { + "localizations" : { + "ja" : { + "stringUnit" : { + "state" : "translated", + "value" : "友だちを探す" + } + } + } + }, + "God cares intensely about your privacy.\nWeb will never text or spam your contacts." : { + "localizations" : { + "ja" : { + "stringUnit" : { + "state" : "translated", + "value" : "あなたの個人情報は安全に管理されます。\nメールやスパムを送ることはありません。" + } + } + } + }, + "God uses your contacts\nto find friends" : { + "localizations" : { + "ja" : { + "stringUnit" : { + "state" : "translated", + "value" : "Godは友だちを見つけるために\n連絡先を利用します" + } + } + } + } + }, "version" : "1.0" -} +} \ No newline at end of file diff --git a/Packages/GodPackage/Sources/OnboardFeature/Localizable.xcstrings b/Packages/GodPackage/Sources/OnboardFeature/Localizable.xcstrings index 6d51df85..337e57f3 100644 --- a/Packages/GodPackage/Sources/OnboardFeature/Localizable.xcstrings +++ b/Packages/GodPackage/Sources/OnboardFeature/Localizable.xcstrings @@ -196,16 +196,6 @@ } } }, - "Find My Friends" : { - "localizations" : { - "ja" : { - "stringUnit" : { - "state" : "translated", - "value" : "友だちを探す" - } - } - } - }, "Finished High School" : { "localizations" : { "ja" : { @@ -269,28 +259,8 @@ } } }, - "God cares intensely about your privacy.\nWeb will never text or spam your contacts." : { - "localizations" : { - "ja" : { - "stringUnit" : { - "state" : "translated", - "value" : "あなたの個人情報は安全に管理されます。\nメールやスパムを送ることはありません。" - } - } - } - }, "God needs to find your school and suggest friends." : { - }, - "God uses your contacts\nto find friends" : { - "localizations" : { - "ja" : { - "stringUnit" : { - "state" : "translated", - "value" : "Godは友だちを見つけるために\n連絡先を利用します" - } - } - } }, "godappteam" : { "localizations" : {