Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account and note script compilation with packaging (tracking) #139

Closed
greenhat opened this issue Mar 4, 2024 · 2 comments
Closed

Account and note script compilation with packaging (tracking) #139

greenhat opened this issue Mar 4, 2024 · 2 comments

Comments

@greenhat
Copy link
Contributor

greenhat commented Mar 4, 2024

This is a tracking issue for everything needed for a user to be able to compile an account and note script code.

Goal

A developer should be able to compile an account and note script code in Rust (like basic wallet example and P2ID note script example). The account and note script code should be able to use the kernel tx API and stdlib.

Tasks

Preview Give feedback
No tasks being tracked yet.

Notes

For account compilation, only Miden package generation in cargo extension is needed.
For note script compilation, Miden packages as WIT dependencies support in cargo extension is required. To use account Miden packages as a dependency in the note script.

@greenhat greenhat changed the title Account compilation support Account and note script compilation support Mar 4, 2024
@greenhat greenhat changed the title Account and note script compilation support Account and note script compilation (tracking issue) Mar 7, 2024
@greenhat greenhat changed the title Account and note script compilation (tracking issue) Account and note script compilation with packaging (tracking) Mar 8, 2024
@greenhat greenhat removed this from the End of Q1 - Rust Toolchain Beta milestone Mar 8, 2024
@bitwalker
Copy link
Contributor

@greenhat I think this issue overlaps a bit too much with #141, as they have virtually identical requirements. Some dependencies of being able to implement proper account compilation require packaging, so there isn't really a distinction between supporting account compilation and supporting account compilation + packaging.

We could modify this issue to be about publishing/distributing account/note script artifacts, and the integration with the Miden client, but it might be better to wait until we get closer to implementation to start tracking the requirements.

@greenhat
Copy link
Contributor Author

greenhat commented Sep 6, 2024

@greenhat I think this issue overlaps a bit too much with #141, as they have virtually identical requirements. Some dependencies of being able to implement proper account compilation require packaging, so there isn't really a distinction between supporting account compilation and supporting account compilation + packaging.

I agree. A packaging is required at account stage, since we cannot just bolt it on later when we start working on note scripts.

We could modify this issue to be about publishing/distributing account/note script artifacts, and the integration with the Miden client, but it might be better to wait until we get closer to implementation to start tracking the requirements.

I agree, local deps is the way to go for the MVP.

I added the tasks to this issue that I think we're missing for MVP and are "note-only". I'm fine with merging it with #141.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants