Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep local Rust toolchain version in sync with CI automatically. #45

Closed
greenhat opened this issue Oct 20, 2023 · 3 comments
Closed

Keep local Rust toolchain version in sync with CI automatically. #45

greenhat opened this issue Oct 20, 2023 · 3 comments
Assignees

Comments

@greenhat
Copy link
Contributor

Set the Rust toolchain version via rust-toolchain.toml and use it in 'cargo make`.
See details at https://rust-lang.github.io/rustup/overrides.html#the-toolchain-file

@greenhat greenhat self-assigned this Oct 23, 2023
@bitwalker
Copy link
Contributor

I've added a rust-toolchain.toml file to the repo, and set it to the nightly toolchain until the trait_upcasting feature is stabilized in the next release, then we'll switch back to stable. In any case, it'll be easier to keep things in sync using that from now on.

Added in #50

@greenhat
Copy link
Contributor Author

greenhat commented Nov 10, 2023

cargo-make on CI is still driven by CARGO_MAKE_TOOLCHAIN env var set in ci.yml. So in order to simulate CI on a local machine one needs to set this env var. I guess removing the env var might be enough for cargo-make to follow the rust-toolchain.toml.

@greenhat greenhat reopened this Nov 10, 2023
@greenhat
Copy link
Contributor Author

Done in #91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants