Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue: Finalize STARK recursive verifier #971

Closed
2 tasks done
Al-Kindi-0 opened this issue Jun 28, 2023 · 1 comment
Closed
2 tasks done

Tracking issue: Finalize STARK recursive verifier #971

Al-Kindi-0 opened this issue Jun 28, 2023 · 1 comment

Comments

@Al-Kindi-0
Copy link
Collaborator

Al-Kindi-0 commented Jun 28, 2023

Goal(s)

  • Make the recursive verifier in Miden VM standard library production-ready.

Details

With #717 and #858, we have a functional and relatively performant recursive verifier for Miden VM. The goal now is to close some remaining issues in order to make it ready for production use.

Must have

Preview Give feedback
  1. Al-Kindi-0

Nice to have

Preview Give feedback
No tasks being tracked yet.

Working group:

@Al-Kindi-0, @bobbinth

Workflow
  • Discussion should happen here or in the related sub-issues.
  • PRs should only be merged by the coordinator, to ensure everyone is able to review.
  • Aim to complete reviews within 24 hours.
  • When a related sub-issue is opened:
    • add it to the list of sub-issues in this tracking issue
  • When opening a related PR:
    • request review from everyone in this working group
  • When a sub-issue is completed:
    • close the related issue with a comment that links to the PR where the work was completed

Coordinator: @Al-Kindi-0

The working group coordinator ensures scope & progress tracking are transparent and accurate. They will:

  • Merge approved PRs after all working group members have completed their reviews.
    • add the PR # to the relevant section of the current tracking PR.
    • close any completed sub-issue(s) with a comment that links to the PR where the work was completed
  • Monitor workflow items and complete anything that slips through the cracks.
  • Monitor scope to see if anything is untracked or unclear. Create missing sub-issues or initiate discussion as required.
  • Monitor progress to see if there's anything which isn't moving forward. Initiate discussion as required.
  • Identify PRs with especially significant changes and add @grjte and @bobbinth for review.
@Al-Kindi-0
Copy link
Collaborator Author

Superseded by #1632

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant