Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default contract limits should be the same as on Starknet #640

Open
FabijanC opened this issue Oct 31, 2024 · 0 comments
Open

Default contract limits should be the same as on Starknet #640

FabijanC opened this issue Oct 31, 2024 · 0 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@FabijanC
Copy link
Contributor

FabijanC commented Oct 31, 2024

Description

True, users can configure the limits related to request size and similar (as documented here), but ideally their default values would be equal to the ones used by Starknet. This was reported to me on Telegram in a private message.

To limit the contract size (not the request size), this method from blockfier can be used: ContractClass::bytecode_length and the constants specified here, as mentioned on Slack

Classification

If already being able to configure the limits is satisfying, then this issue is merely an enhancement proposal. One might argue that this is a bug, so I'm also putting both labels.

Questions

How should it be implemented? Should there be something which automatically fetches the limits from a trusted source? Should the values be updated manually, but regularly?

@FabijanC FabijanC added bug Something isn't working enhancement New feature or request labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
Status: 🆕 New
Development

No branches or pull requests

1 participant