Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] The problem that the website reverse proxy cannot be deleted #7701

Open
hkfires opened this issue Jan 11, 2025 · 13 comments
Open

[Bug] The problem that the website reverse proxy cannot be deleted #7701

hkfires opened this issue Jan 11, 2025 · 13 comments
Assignees
Milestone

Comments

@hkfires
Copy link

hkfires commented Jan 11, 2025

Contact Information

[email protected]

1Panel Version

v1.10.23-lts

Problem Description

通过面板安装了OpenResty后,在网站中添加反向代理,如果手动把反向代理的proxy_pass修改为grpc_pass,例如下图
1
就无法在面板中删除该反向代理,需要手动把grpc_pass改回到proxy_pass才能够删除。

Steps to Reproduce

1、网站添加反向代理,按要求输入必填项
2、点击该反向代理的源文,将proxy_pass修改为grpc_pass,例如下图
1
3、保存后,尝试在面板中删除该反向代理,面板报错
4、手动将grpc_pass改回到proxy_pass,保存后再尝试在面板中删除该反向代理,成功删除

The expected correct result

No response

Related log output

No response

Additional Information

No response

@wanghe-fit2cloud wanghe-fit2cloud changed the title [Bug] 网站反向代理无法删除的问题 [Bug] The problem that the website reverse proxy cannot be deleted Jan 11, 2025
@zhengkunwang223
Copy link
Member

image
我使用你的配置直接保存 是报错的 无法通过 nginx 的校验
使用 grpc_pass 需要 ngx_http_grpc_module , 默认情况下 没有这个 module
我们会在 v2 版本增加自定义 module 的功能

@wanghe-fit2cloud
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


image
When I save it directly using your configuration, an error is reported and cannot pass nginx verification.
Using grpc_pass requires ngx_http_grpc_module. This module is not available by default.
We will add the function of custom module in v2 version

@hkfires
Copy link
Author

hkfires commented Jan 11, 2025

image 我使用你的配置直接保存 是报错的 无法通过 nginx 的校验 使用 grpc_pass 需要 ngx_http_grpc_module , 默认情况下 没有这个 module 我们会在 v2 版本增加自定义 module 的功能

2025-01-11_11-03-22.mp4

但是我保存的时候是没有报错并能够正常使用的,我已经在多台服务器上这么操作的,都是正常的,只有今天想删除一个grpc反向代理的时候,才发现这个问题

@wanghe-fit2cloud
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


![image](https://private-user-images.githubusercontent.com/31820853/402195137-936659e0-5fc4-4607-b 9cf-b10b7065b9ab.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoic mF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY1NjQ3MzgsIm5iZiI6MTczNjU2NDQzOCw icGF0aCI6Ii8zMTgyMDg1My80MDIxOTUxMzctOTM2NjU5ZTAtNWZjNC00NjA3LWI5Y2YtYjEwYjcwNjViOWFiLnBuZz9YLUFtei 1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAx MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMTExVDAzMDAzOFomWC1BbXotRXhwaXJ lcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg4MWE2ZjRjYjFiMzZhMzdkNzAyYmMwNzY5ODg4NzQzMzVkYjY2ODMzOGRmMjM5MjJmZ DFmZmQxNmEwY2QyNTUmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.ZLmhlx4BkG0iRD9yzxE21M9P2pT_j1qZDKfRHFloA88) I used your configuration to save it directly, but it reported an error. It could not pass nginx verification. Using grpc_pass requires ngx_http_grpc_module. By default, this module does not exist. We will add the function of custom module in v2 version.

2025-01-11_11-03-22.mp4

But when I saved it, there was no error and it could be used normally. I have done this on multiple servers and it was normal. I only discovered this problem when I wanted to delete a grpc reverse proxy today.

@zhengkunwang223
Copy link
Member

能否提供环境我们试一下
image
加我企业微信

@wanghe-fit2cloud
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Can you provide an environment for us to try?
image
Add my business WeChat

@hkfires
Copy link
Author

hkfires commented Jan 11, 2025

能否提供环境我们试一下 image 加我企业微信

环境很简单,就是新装的debian12,通过1panel安装了OpenResty,再在网站中添加反向代理网站。因为几台服务器上我都部署了业务,环境不好提供,我录个完整的视频吧

@wanghe-fit2cloud
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


Can you provide an environment for us to try? ![image](https://private-user-images.githubusercontent.com/31820853/402196265-f6db8632-9a4f-4dc8-9 557-9b03639fde0f.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoic mF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzY1NjU2ODMsIm5iZiI6MTczNjU2NTM4Myw icGF0aCI6Ii8zMTgyMDg1My80MDIxOTYyNjUtZjZkYjg2MzItOWE0Zi00ZGM4LTk1NTctOWIwMzYzOWZkZTBmLnBuZz9YLUFtei 1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAx MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMTExVDAzMTYyM1omWC1BbXotRXhwaXJ lcz0zMDAmWC1BbXotU2lnbmF0dXJlPTIzZDRiZWQyMGIyODYyODBkMjE3ZTJhYjdlYWJlN2ExOWM4ZjZmOGQyY2Y1NmQxYTg5M jY3MDVlNjEyMDAxNmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.iZzKgJ7Tn3jb8fiqXsKxUvvehUxe4ZXc93fhz_6dMpM) Add my business WeChat

The environment is very simple, it is a newly installed debian12, installed OpenResty through 1panel, and then added a reverse proxy website to the website. Because I have deployed services on several servers and the environment is not easy to provide, I will record a complete video.

@hkfires
Copy link
Author

hkfires commented Jan 11, 2025

2025-01-11_11-22-37.mp4

这是从添加网站开始到删除反向代理的整个流程,考虑到隐私部分画面遮挡了,但是应该不影响理解

@wanghe-fit2cloud
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


2025-01-11_11-22-37.mp4

This is the entire process from adding a website to deleting the reverse proxy. Some parts of the screen are blocked due to privacy considerations, but it should not affect understanding.

@zhengkunwang223
Copy link
Member

zhengkunwang223 commented Jan 11, 2025

看到视频了 后面我们把接口的校验处理一下应该就可以了

@wanghe-fit2cloud
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿


It's a bit strange that it can't be reproduced locally. Take a screenshot to see what error is reported after deleting it.

@zhengkunwang223 zhengkunwang223 added this to the v1.10.24-lts milestone Jan 11, 2025
@hkfires
Copy link
Author

hkfires commented Jan 11, 2025

请求参数错误: Key: 'WebsiteProxyConfig.ProxyPass' Error:Field validation for 'ProxyPass' failed on the 'required' tag Key: 'WebsiteProxyConfig.ProxyHost' Error:Field validation for 'ProxyHost' failed on the 'required' tag

这是报错信息,就是删除的时候配置中相关反向代理的字段找不到,就不让删除了

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants