-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Message signing and verification #130
Comments
Mh why do you need to sign a message if phoenix at this stage is not giving you the possibility to generate an on-chain address? What do you need to sign? |
I mentioned that in my OP:
|
We think the offers need 2 parameters too, "Amount" & "Description". With this and the "signature" feature, the little miners can get payments via #Bolt12 by Ocean Pool with PhoenixD. |
@dekdynamics My point is that you can not use the Phoenix sign message if you cannot generate an on-chain address from Phoenix itself. The code example that you are proposing by using lnd verify message is using the key of the node and not the BIP that ocean is using. |
@vincenzopalazzo we agree. We think they only need the parameters "amount" & "description" in the offers and sign this offer with their Keys of the Bitcoin Mining Address in Ocean. Make sense sign the offer with the bitcoin mining address to verify the owner. |
OK so now this issue does not make anymore sense! The description is another discussion that not involved ocean directly but it is just a use case. Please see ACINQ/lightning-kmp#729 So I think this issue can be close! |
Hi Team,
Please add functionality to sign and verify messages with phoenix-cli.
For example, with lnd:
This is required in order to configure BOLT12 payouts on OCEAN pool.
The text was updated successfully, but these errors were encountered: