Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Message signing and verification #130

Open
dekdynamics opened this issue Dec 3, 2024 · 6 comments
Open

Feature request: Message signing and verification #130

dekdynamics opened this issue Dec 3, 2024 · 6 comments

Comments

@dekdynamics
Copy link

Hi Team,

Please add functionality to sign and verify messages with phoenix-cli.

For example, with lnd:

$ lncli signmessage "my message"
{
    "signature": "dhmzdatnd6uzaihnnj3rgxf46d9dz4moam1robknis33675ktomfyxwg54xpksgapsxhe6oc6y46m3afncerzxcuh3bkcja71y4n5ku1"
}
$ lncli verifymessage "my message" "dhmzdatnd6uzaihnnj3rgxf46d9dz4moam1robknis33675ktomfyxwg54xpksgapsxhe6oc6y46
m3afncerzxcuh3bkcja71y4n5ku1"
{
    "valid": true,
    "pubkey": "0201e5b16ebe87b089f22e18752f1f7a66a1bdf77879df8d1c9e8d912dbfb9beb5"
}

This is required in order to configure BOLT12 payouts on OCEAN pool.

@vincenzopalazzo
Copy link

Mh why do you need to sign a message if phoenix at this stage is not giving you the possibility to generate an on-chain address?

What do you need to sign?

@dekdynamics
Copy link
Author

I mentioned that in my OP:

This is required in order to configure BOLT12 payouts on OCEAN pool.

@SatoshiNakamotoBitcoin
Copy link

We think the offers need 2 parameters too, "Amount" & "Description".

With this and the "signature" feature, the little miners can get payments via #Bolt12 by Ocean Pool with PhoenixD.

@vincenzopalazzo
Copy link

@dekdynamics My point is that you can not use the Phoenix sign message if you cannot generate an on-chain address from Phoenix itself. The code example that you are proposing by using lnd verify message is using the key of the node and not the BIP that ocean is using.

@SatoshiNakamotoBitcoin
Copy link

SatoshiNakamotoBitcoin commented Dec 26, 2024

@vincenzopalazzo we agree.

We think they only need the parameters "amount" & "description" in the offers and sign this offer with their Keys of the Bitcoin Mining Address in Ocean.

Make sense sign the offer with the bitcoin mining address to verify the owner.

@vincenzopalazzo
Copy link

OK so now this issue does not make anymore sense!

The description is another discussion that not involved ocean directly but it is just a use case. Please see ACINQ/lightning-kmp#729

So I think this issue can be close!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants