Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "always push on PR" flag into config #72

Open
vpavlin opened this issue Oct 7, 2020 · 7 comments
Open

Add "always push on PR" flag into config #72

vpavlin opened this issue Oct 7, 2020 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@vpavlin
Copy link

vpavlin commented Oct 7, 2020

Is your feature request related to a problem? Please describe.
For some repositories I always run /deploy to get image pushed to quay.io to be able to easily test the changes. I

Describe the solution you'd like
I'd like to be able to set a configuration which will result for the pipeline to always push the PR build to registry without the need to add /deploy comment

e.g.

push_on_pr: true

Ideally, the pipeline should also comment on the PR when the push is done and it should provide a link to the new image

Describe alternatives you've considered
Keep using the /deploy command. Although possible, it is not a good user experience

Additional context

The image should be also deleted from the registry when the PR is merged to make sure the image repository is not clutterred (see #52)

@harshad16
Copy link
Member

/kind feature

@sesheta sesheta added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 7, 2020
@harshad16
Copy link
Member

Thanks for the feature requests, the following step would be implemented for this feature.
Step for creating the task to serve the feature:

  • create the configuration required on the configuration file.
  • Modify the pull request build pipeline tasks step to push to the registry if this configuration is set.

@sesheta
Copy link
Contributor

sesheta commented Jul 3, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 3, 2021
@harshad16
Copy link
Member

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 6, 2021
@sesheta
Copy link
Contributor

sesheta commented Oct 16, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2021
@sesheta
Copy link
Contributor

sesheta commented Nov 15, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2021
@harshad16
Copy link
Member

/lifecycle frozen

@sesheta sesheta added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants