-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a validation check for configuration file. #80
Comments
@harshad16 I was thinking about this overnight and I think this task can be extended a bit to cover much more if you'd be interested: Instead of a bare check we can choose to generate a proper schema for You can then choose to upload it to https://www.schemastore.org/ so it can be consumed by IDE linters yaml language server (for example in VS Code To facilitate this CI check, the schema can be consumed by a pre-commit hook to do the validation. This can solve both local pre-commit runs as well as there's no need to create a special case pipeline in CI, the pre commit CI job would cover it. Some resources: |
/kind feature |
thanks, @tumido for the suggestion, seems like a good approach. I will go over the resources your shared 👍 |
Can I join and work on this ? |
surely, welcome @anushkrishnav |
I would love to start with easier issues and go one to advanced ones |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
/remove-lifecycle stale |
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with /lifecycle rotten |
/lifecycle frozen |
Is your feature request related to a problem? Please describe.
aicoe-ci should have a validation check on the configuration file, as mistakenly users can define the keys wrong in the configuration file, which may lead to erroneous development.
Describe the solution you'd like
YAML file validation is to be present in the pipeline, to check the
.aicoe-ci.yaml
file.Describe alternatives you've considered
Leave it to the user to maintain the correct configuration file.
Additional context
operate-first/support#17
The text was updated successfully, but these errors were encountered: