Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MoveEffect class #18

Open
AJ2O opened this issue Nov 19, 2020 · 0 comments
Open

Refactor MoveEffect class #18

AJ2O opened this issue Nov 19, 2020 · 0 comments
Labels
Epic refactor Removing/Replacing legacy code

Comments

@AJ2O
Copy link
Owner

AJ2O commented Nov 19, 2020

The MoveEffect class was an early implementation of how move effects were handled. It is being replaced by "PBS.Databases.Effects.Move", which contains more readable and flexible effect definitions.

Some of the legacy move effects are still referenced and used (ex. Focus Punch, Pay Day), and should be replaced by their counterparts in the aforementioned class.
@AJ2O AJ2O added the Epic label Nov 19, 2020
@AJ2O AJ2O changed the title Phase Out MoveEffect class Refactor MoveEffect class Nov 20, 2020
@AJ2O AJ2O added the refactor Removing/Replacing legacy code label Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic refactor Removing/Replacing legacy code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AJ2O