Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect a list of example calendars to test on #8

Open
Robinlovelace opened this issue Aug 12, 2018 · 6 comments
Open

Collect a list of example calendars to test on #8

Robinlovelace opened this issue Aug 12, 2018 · 6 comments
Milestone

Comments

@Robinlovelace
Copy link
Member

Eventually these can go into the tests but for now good enough is just to list them.

So far we have:

Any others people find, please add links in comments below.

@Robinlovelace
Copy link
Member Author

OK this should keep us busy for a while and ensure pretty good coverage: https://github.com/mozilla-comm/ical.js/tree/master/samples

@Robinlovelace
Copy link
Member Author

Robinlovelace commented Aug 14, 2018

It now reads-in my calendar - some of the fields are not formatted right, but this is major progress: we can read-in calendars from the wild: https://atfutures.github.io/ical/#trying-on-calendars-in-the-wild

@mpadge and @layik can you please try to find calendars that break ic_read()?

Next priority I think is to sort out all the different types of timestamp, the output in the above example is in character format and is a mess! Hence restricting the output to:

c("DESCRIPTION", "SUMMARY", "DTSTART", "DTEND", "STATUS", "SEQUENCE", "LOCATION")

@mpadge
Copy link
Member

mpadge commented Aug 14, 2018

In case it helps, I've got a standalone C++ lib that coverts almost any arbitrarily messy timestamps to standard format: https://github.com/mpadge/cpp-datetime-convert

@Robinlovelace
Copy link
Member Author

I think so++

@Robinlovelace
Copy link
Member Author

May be overkill though. If you could demo how it would deal with these text strings that would be awesome - it's good it can handle mess as ical timestamps seem messy to me:

ical::ical_example[c(7, 9, 15)]
#> [1] "X-WR-TIMEZONE:Europe/London"    "DTSTART:20180809T160000Z"      
#> [3] "LAST-MODIFIED:20180807T133712Z"
ical::ical_outlook[[2]][c(7, 11)]
#> [1] "DTSTART;TZID=GMT Standard Time:20180515T100000"
#> [2] "DTSTAMP:20180814T134259Z"

Created on 2018-08-14 by the reprex package (v0.2.0).

@Robinlovelace
Copy link
Member Author

Note: slightly less messy text strings can be accessed as follows (note: ic_vector() unhelpfully removes the timezone value - that's a new one for me, hence the X):

ical::ic_vector(ical::ical_example[c(7, 9, 15)])
#>            DTSTART      LAST-MODIFIED 
#> "20180809T160000Z" "20180807T133712Z"
ical::ic_vector(ical::ical_outlook[[2]][c(7, 11)])
#> DTSTART;TZID=GMT Standard Time                        DTSTAMP 
#>              "20180515T100000"             "20180814T134259Z"

Created on 2018-08-14 by the reprex package (v0.2.0).

@Robinlovelace Robinlovelace added this to the CRAN milestone Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants