New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockValidationDataInherentDataProvider gets the correct parachain Block number #1231

Open

syan095 opened this issue Jul 20, 2021 · 0 comments

Labels

C5-misc T2-optimization

Contributor

syan095 commented Jul 20, 2021

There are some other codebase that gets the correct block number from the client, instead of defaulting to 0
https://github.com/search?q=current_para_block&type=code

Doing so right now on Acala causes:

memory issue - object is "moved" so the capture is FnOnce instead of Fn
Lifetime: some variable may not live as long as the capture
These problems causes the code to fail to compile, and further investigation is needed.

syan095 added C5-misc T2-optimization labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment