Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mint to a different address than users #47

Open
2 tasks
amiller opened this issue Nov 15, 2024 · 0 comments
Open
2 tasks

Allow mint to a different address than users #47

amiller opened this issue Nov 15, 2024 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@amiller
Copy link
Contributor

amiller commented Nov 15, 2024

This feature is part of "frontend abstraction", allowing different front ends by relying only on TEE delivered backend to make sure users are shown what they are about to approve.

Right now this line prevents the address in the query from minting to any other recipient than the logged in users themselves

if session.x_id != user.x_id.clone().unwrap() {

To fix this,

  • have a separate queury variable, a second optional address for "recipient" that can differ than the user address
  • mint to this address instead
@amiller amiller added enhancement New feature or request good first issue Good for newcomers labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant