Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular 9 ng build --prod error #39

Open
silverio opened this issue Feb 7, 2020 · 8 comments
Open

Angular 9 ng build --prod error #39

silverio opened this issue Feb 7, 2020 · 8 comments

Comments

@silverio
Copy link

silverio commented Feb 7, 2020

Hi,

I recently updated my app to angular 9 and it works fine with ng serve, but when I try to build it with ng build --prod I get the following error: ERROR in node_modules/agm-overlays/AgmOverlays.module.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of MapPageModule, but could not be resolved to an NgModule class any idea on how to resolve this issue?

@AckerApple
Copy link
Owner

Historically Angular releases a breaking version and it breaks dependencies. And then the package, aka dependency, and then adopters complain it no longer works with their version.

It’s a crazy game we play with Angular.

This package most likely just needs to be built with Angular 9 now

@gae123
Copy link

gae123 commented Feb 7, 2020

@AckerApple thanks for your open source effort and I do feel your pain. Having said that, the ng team has been releasing ng9 betas for a long time. We have a huge list of dependencies, I had issues with many of them but when I upgraded to the latest version the issues went away. Right now the only dependency that prevents us from building with ng 9 is this project. My team would appreciate your attention to this as soon as feasible with your schedule.

@AckerApple
Copy link
Owner

I just bundled my other popular library, angular-file, using Angular 9 with Ivy turned on. It looks like a success but I JUST released it, version 3.0.0, minutes ago.

I will attempt to do the same thing to this library coming soon. I have two other Angular libraries, same thing. So I hear the need, a bit rather busy though.

@AckerApple
Copy link
Owner

Success! Someone reported already reported success with my other package upgrade to Angular 9

This package, now version 2.0.0, is built on Angular 9. This version of Angular, 9, sure does build faster and smaller.

Marking issue as ready to close

@fpeterdev
Copy link

@AckerApple Could you publish a changelog for 2.0.0?

@AckerApple
Copy link
Owner

AckerApple commented Feb 20, 2020

Naaaaaaa, I don’t use this code in anyway and so I updated just Angular version is all just for y’all

@guybmayor
Copy link

what about an update to angular 10?

@AckerApple
Copy link
Owner

We could totally do that. I had a PR on angular-file for someone wanting Angular 10 support enough to make a PR for it and I accepted.

If you’d like to make a PR for this package to support NG10 please help. Otherwise I will get to it relatively soon. One man band here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants