Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note that your releases contain the wrong file, which has been overridden by PrestaShop #281

Closed
dpuhach opened this issue Dec 3, 2024 · 9 comments

Comments

@dpuhach
Copy link

dpuhach commented Dec 3, 2024

The following file's content has been overridden with the default PrestaShop's index.php:
https://github.com/Adyen/adyen-php-plugin-core/blob/main/src/Infrastructure/ORM/Configuration/Index.php

@adyen-integrations-support

Hello @dpuhach ,

Thank you for reaching out. This is just a quick note to inform you that we received your ticket.

We will take this issue into consideration as soon as possible.

Best regards.

@adyen-integrations-support

Hey @dpuhach

Once we have new information about this issue we will let you know.

Best regards.

@adyen-integrations-support
Copy link

adyen-integrations-support commented Jan 10, 2025

Hey @dpuhach

Could you please confirm if this issue still persists? From the communication here, it appears to have been resolved.

Best regards.

@dpuhach
Copy link
Author

dpuhach commented Jan 10, 2025

Could you please confirm if this issue still persists? From the communication here, it appears to have been resolved.

Hi @adyen-integrations-support

Maybe it was resolved in the older release, but the latest release contains this issue again.

How to check this:

  1. Please download the latest release: https://github.com/Adyen/adyen-prestashop/releases/download/5.2.6/adyenofficial.zip
  2. Check this file inside: vendor/adyen/integration-core/src/Infrastructure/ORM/Configuration/index.php

@adyen-integrations-support

Hi @dpuhach ,

We will check the latest release and check the file you mentioned. Once we’ve completed our analysis, we’ll get back to you with more information.

Thank you for your patience in the meantime.

Best regards

@adyen-integrations-support

Hi @dpuhach ,

The mentioned file (https://github.com/Adyen/adyen-php-plugin-core/blob/main/src/Infrastructure/ORM/Configuration/Index.php ) is not overridden in the release archive. The archive contains both the default Prestashop index.php and the mentioned Index.php (note the capital letter I).

Let us know if you need further assistance.

Best regards

@dpuhach
Copy link
Author

dpuhach commented Jan 21, 2025

The mentioned file (https://github.com/Adyen/adyen-php-plugin-core/blob/main/src/Infrastructure/ORM/Configuration/Index.php ) is not overridden in the release archive. The archive contains both the default Prestashop index.php and the mentioned Index.php (note the capital letter I).

Let us know if you need further assistance.

My apologies, indeed I didn't notice this as the archive was unzipped directly in Finder (MacOS), in which case the file overwrite warning wasn't displayed.

However, this doesn't solve the issue of the two files not being able to exist at the same time due to the lack of case sensitivity in MacOS + with HFS+ or APFS.

@adyen-integrations-support

Hi @dpuhach ,

The class has been renamed to avoid filename collisions, and this change will be included in the next plugin release.

We will inform you as soon as the new plugin version is available.

Best regards

@adyen-integrations-support

Hi @dpuhach ,

We wanted to inform you that we have released the new version of the plugin.

https://github.com/Adyen/adyen-prestashop/releases/tag/5.2.8

Please let us know if you need any assistance with the update or if you encounter any issues.

Best regards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants