Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Same styles used for eIDAS and SPID access buttons #9

Open
mauromol opened this issue Aug 2, 2021 · 0 comments
Open

Same styles used for eIDAS and SPID access buttons #9

mauromol opened this issue Aug 2, 2021 · 0 comments

Comments

@mauromol
Copy link

mauromol commented Aug 2, 2021

The CSS file for the eIDAS access button present here contains declarations about styles named as italia-it-button[-*].
The same style names are used for the SPID SP access button.

These final result is that if you want to put the SPID access button and the eIDAS access button on the same page, as per AgID guidelines, and you then import both CSS files in your HTML page, styles from the eIDAS CSS will override those from the SPID CSS.
The most visible result is that the SPID access button will have rounded corners, instead of straight ones.

See, for instance:


which is the same style used at:
https://github.com/italia/spid-sp-access-button/blob/2fe1955ac8d267b7399d1dca3ed92ed05c5fb030/src/production/spid-sp-access-button.html#L18
however it brings border-radius: 15px.

Possibile solutions:

  • rename the italia-it-button[-*] styles in either this eIDAS access button or SPID access button (I would say it's better to change them here)
  • limit the scope of the italia-it-button[-*] styles with a CSS descendant selector in both projects so that they are applied only when those styles appear within a HTML container with a unique id or style (but this may perhaps also require changes to the HTML pages... I've not investigated further)
@mauromol mauromol changed the title Same styles used for eIDAS and SPID access button Same styles used for eIDAS and SPID access buttons Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant