Error : 'no ordinal for "[Alleged: Dummy brand]"'

[Jorge-Lopes]

Greetings,
I am trying to solve the following error.
Probably I am forgetting a simple step, but when searching by error message in Agoric Issues it points to durable store, (#7105), which I assume it is not the case.

Thank you in advance :)

Error being solved:

While trying to make an offer, the following error is returned:

Temporary logging of sent error (Error#1)
CapTP near-zoeTest exception: (RemoteError(error:captp:far-zoeTest#20001)#2)
  ✖ Test dummy contract Rejected promise returned by test
Error#1: no ordinal for Object [Alleged: Dummy brand] {}
  at encodeRemotable (packages/swingset-liveslots/src/collectionManager.js:232:36)
  at keyToDBKey (packages/swingset-liveslots/src/collectionManager.js:277:26)
  at Alleged: weakMapStore.get (packages/swingset-liveslots/src/collectionManager.js:300:42)
  at getByBrand (packages/zoe/src/issuerStorage.js:79:32)
  at Object.getAssetKindByBrand (packages/zoe/src/issuerStorage.js:135:12)
  at Alleged: ZoeStorageManager makeOfferAccess.method (packages/store/src/patterns/exo-tools.js:149:18)
  at Alleged: ZoeStorageManager makeOfferAccess.In "getAssetKindByBrand" method of (ZoeStorageManager makeOfferAccess) [as getAssetKindByBrand] (packages/store/src/patterns/exo-tools.js:32:22)
  at getAssetKindByBrand (packages/zoe/src/zoeService/offer/offer.js:43:30)
  at packages/zoe/src/cleanProposal.js:66:30
  at Array.map (<anonymous>)
  at coerceAmountPatternKeywordRecord (packages/zoe/src/cleanProposal.js:64:34)
  at coerceAmountKeywordRecord (packages/zoe/src/cleanProposal.js:87:18)
  at cleanProposal (packages/zoe/src/cleanProposal.js:153:23)
  at Object.offer (packages/zoe/src/zoeService/offer/offer.js:46:22)

Error#1 ERROR_NOTE: Sent as error:captp:far-zoeTest#20001
RemoteError(error:captp:far-zoeTest#20001)#2: no ordinal for "[Alleged: Dummy brand]"
Error: no ordinal for "[Alleged: Dummy brand]"

  ─

  Test dummy contract

  Rejected promise returned by test. Reason:

  Error {
    message: 'no ordinal for "[Alleged: Dummy brand]"',
  }

  ─

Context

Contract:

import { Far } from '@endo/marshal';
import { M } from '@agoric/vat-data';
import { AmountShape } from '@agoric/ertp';

const start = async (zcf) => {

  const { zcfSeat } = zcf.makeEmptySeatKit();
  
  const dummyHook = (userSeat) => {
    const { give: {In: givenAmount }} = userSeat.getProposal();
    zcfSeat.incrementBy(userSeat.decrementBy(harden({ In: givenAmount })));
    zcf.reallocate(zcfSeat, userSeat);
    userSeat.exit();

    return 'Sucess';
  };
  
  const makeDummyInvitation = () => {
    return zcf.makeInvitation(
      dummyHook,
      'dummy',
      undefined,
      M.splitRecord({
        give: { In: AmountShape },
      }),
    );
  };

  const creatorFacet = Far('creatorFacet', {
    makeDummyInvitation,
  });

  return { creatorFacet };
};

harden(start);
export { start };

Test Setup:

export const setUpDummy = async (zoe) => {
  const sourceRoot = '../src/dummyContract.js';
  const contractUrl = await importMetaResolve(sourceRoot, import.meta.url);
  const contractPath = new URL(contractUrl).pathname;
  const contractBundle = await bundleSource(contractPath);
  const installation = await E(zoe).install(contractBundle);
  const { creatorFacet } = await E(zoe).startInstance(
    installation,
  );
  return {
    creatorFacet,
  };
};
harden(setUpDummy);

Test being executed:

test.only('Test dummy contract', async (t) => {
  const { zoe } = await setUpZoeForTest(() => {});
  const { creatorFacet } = await setUpDummy(zoe);

  const dummyKit = makeIssuerKit('Dummy');
  const { brand } = dummyKit;
  const dummyAmount = AmountMath.make(brand, 100n);

  const invitation = await E(creatorFacet).makeDummyInvitation();
  const proposal = harden({ give: { In: dummyAmount } });
  const payment = harden({ In: dummyKit.mint.mintPayment(dummyAmount) });

  const userSeat = await E(zoe).offer(invitation, proposal, payment);

  const result = await E(userSeat).getOfferResult();

  t.deepEqual(result, 'Sucess');
});

[Chris-Hibbert]

The error message is pretty generic, and gives almost no hint as to where the problem is. What it means was that a key (Alleged: Dummy Brand) wasn't found in a store. At the time the lookup was attempted, the callee has no connection to the call stack of the caller. Still, it would help if the error message at least reported what store the lookup was being done in. Our stores do have names, even though they're not guaranteed unique.

When it's a brand like this, I often suspect that an issuer hasn't been registered with Zoe for a particular contract. In this case, I think startInstance wants an issuerKeywordRecord { In: dummyKit.issuer }.

[warner]

Thanks for spotting the problem with the error message. I filed a bug with more details (#7231), and made a patch to improve it (#7233) that should land soon.

[erights]

#7233 landed. Should be fixed.

[Jorge-Lopes]

Thank you for your help!

[dckc]

Thanks for the detailed problem report. @warner tells me it helped quite a bit in diagnosing the issue.