Node version checks are inconsistent #9622
Labels
bug
Something isn't working
Comments
mergify bot
added a commit
that referenced
this issue
Jul 1, 2024
refs: #9622 ## Description Enforce the Node.js version in agd builder. Reverts #9619 This enforces LTS range, aka `^18.12` or `^20.9` through a regexp similar to the golang version check. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations We'll need to update release notes for validators to use `agd build` instead of the former `yarn install` and `yarn build` as that may still fail. If they still chose to go that route, they're on their own. ### Testing Considerations CI covers `agd build` ### Upgrade Considerations Smooth the transition away from previously supported Node v16 in upgrade-15
mhofman
pushed a commit
that referenced
this issue
Jul 1, 2024
refs: #9622 ## Description Enforce the Node.js version in agd builder. Reverts #9619 This enforces LTS range, aka `^18.12` or `^20.9` through a regexp similar to the golang version check. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations We'll need to update release notes for validators to use `agd build` instead of the former `yarn install` and `yarn build` as that may still fail. If they still chose to go that route, they're on their own. ### Testing Considerations CI covers `agd build` ### Upgrade Considerations Smooth the transition away from previously supported Node v16 in upgrade-15
mergify bot
added a commit
that referenced
this issue
Jul 1, 2024
refs: #9622 ## Description #9623 claimed to enforce Node.js versions ^18.12 or ^20.9, but due to a typo allows arbitrarily high versions to pass the check. This corrects it to enforce that the major version is exactly 18 or 20. ### Security Considerations None. ### Scaling Considerations n/a ### Documentation Considerations Matches the [README](https://github.com/Agoric/agoric-sdk?tab=readme-ov-file#prerequisites). ### Testing Considerations Checked by integration testing in CI. ### Upgrade Considerations Will need an update for supporting Node.js v22 when that enters LTS (ref #9265).
gibson042
pushed a commit
that referenced
this issue
Jul 1, 2024
refs: #9622 ## Description #9623 claimed to enforce Node.js versions ^18.12 or ^20.9, but due to a typo allows arbitrarily high versions to pass the check. This corrects it to enforce that the major version is exactly 18 or 20. ### Security Considerations None. ### Scaling Considerations n/a ### Documentation Considerations Matches the [README](https://github.com/Agoric/agoric-sdk?tab=readme-ov-file#prerequisites). ### Testing Considerations Checked by integration testing in CI. ### Upgrade Considerations Will need an update for supporting Node.js v22 when that enters LTS (ref #9265).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Our readme now mentions (#9295) that we officially support Node.js
^18.12or^20.9, aka the LTS versions.We also integration test with the latest-ish of these versions. See #8920
However:
yarn installfails with Node.js>= 18.12 && < 18.18because of an overeager dev dependencyengines. fix: typescript-estree does not support Node.js LTS #9619 attempted to relax the restriction but the patch approach fails as it applies too lateSKIP_DOWNLOAD=false agd buildwill actually attempt to download Node.js 16 which is no longer supported at all. Furthermore, ifSKIP_DOWNLOAD=true(the default), a failing Node.js check isn't fatal allowing to technically continue with untested versionsTo Reproduce
agd buildwith Node.js 18.12Expected behavior
It should build and
agd startshould workScreenshots
The text was updated successfully, but these errors were encountered: