Psi Storm model is substiantially larger than damage radius

[Joshua-Leibold]

I wanted to know if spells dealt with inner radius and stumbled across something... ridiculous

Psi Storm's model is like SUBSTANTIALLY larger than its damage radius. I wondered if at some point in LotV (perhaps even accidentally this recent patch 5.0.13) the radius of the damage was reduced and somebody forgot to reduce the model, but tl.net shows that this only happened way back in the beta 14 years ago when the radius of the damage was reduced from 2->1.5. The worst part is I think my hypothesis is exactly what happened, because reducing the scale of Psi Storm by 25% makes it line back up with its damage radius.

I'm at a loss for how this could've gone undetected for so long

Live: https://gyazo.com/9877d68aae4d400c74b724a783971486

Reducing scale by 25% from 1->0.75 scale on the x and y axis: https://gyazo.com/431a730a326967810a2fe833c1fa4946

It should be noted that my personal recommendation would not be to decrease the storm to this size, even though it would bring it in line with scaling of damage radius to others models like Fungal. I think players have been playing with it so much larger for so long that it might be more prudent to strike a compromise to something like 0.85

[Joshua-Leibold]

I thought this was funny, clearly Dustin Browder agrees with me that this is bullshit: https://youtu.be/VIv5UgCbDho?t=777

After further testing, a more precise replacement value that strikes a reasonable compromise between graphical awe and accuracy is as follows:

<!--Actors-->
<CActorModel id="HighTemplarPsiStormModel">
    <Scale value="0.970000,0.970000,1.150000"/>
</CActorModel>

---

Some additional issues with High Templar models:

1. The Psi-storm impact model scale (the lightning particle effects that spawn ON units that take damage from psistorm) should probably have its scaling adjusted as it spawns too far inside the model of some targets, particularly medium sized units, to be of proper visual indication of the damage (most noticeable when trying to figure out if air units like corruptors are being hit by storm). It should be increased in size for medium-sized targets without affecting the sizing too much on small or large units

Before: https://i.gyazo.com/75f53b9151ed4efbf2113029de688d97.mp4
After: https://i.gyazo.com/39db4794f92dc271ac9acae500a8d2fc.mp4

<!--Models-->
<CActorModel id="HighTemplarPsiStormImpact">
    <AutoScaleFactor value="1.250000"/>
    <MaxScale value="1.250000"/>
</CActorModel>

2. The high templar's weapon attack models are too large for the miniscule amount of damage they inflict. Players judge health/damage based on how "big" or "small" the units/ attacks are, and this weapon projectile and impact explosion are disproportionately large

Before: https://i.gyazo.com/8f3e4c59ad19af8ab704d75ac4828af7.mp4
After: https://i.gyazo.com/7b81c3d2cc1669f2ef682a55bed8e84f.mp4

<!--Models-->
<CModel id="HighTemplarAttackImpact">
    <ScaleMax value="0.650000,0.650000,0.650000"/>
    <ScaleMin value="0.650000,0.650000,0.650000"/>
</CModel>

<CModel id="HighTemplarWeapon">
    <ScaleMax value="0.500000,0.500000,0.500000"/>
    <ScaleMin value="0.500000,0.500000,0.500000"/>
</CModel>