Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auro-accordion: disabled state #123

Open
tfales opened this issue Sep 10, 2024 · 1 comment · May be fixed by #141
Open

auro-accordion: disabled state #123

tfales opened this issue Sep 10, 2024 · 1 comment · May be fixed by #141
Assignees

Comments

@tfales
Copy link

tfales commented Sep 10, 2024

Is your feature request related to a problem? Please describe.

RAIN, an application supporting call centers, is interested in having support around a disabled state of the auro-accordion where a consumer can show initial information within the trigger but the collapse/expand functionality is disabled in the event that there is no additional data/context/information to display.

Describe the solution you'd like

Expand/collapse function is disabled, driven by an attribute, with an eye on accessibility and keyboard support. Other considerations include greying the text and potentially a cursor override on the whole trigger element.

Describe alternatives you've considered

For now, our implementation approach is to allow users to expand/collapse the accordion and within the content we'll show a placeholder message resembling something like "No data" or "Nothing to see here" but more appropriate verbiage given the full context.

Additional context

Here's an example screenshot of an initial design around baggage elements in RAIN. This shows an example of 3 separate accordions with active-expanded, active-collapsed, and inactive (disabled) state. The 3rd row/disabled state is what we're looking for support on. Please feel free to reach out to me with any questions.
image

@tfales tfales added auro-accordion not-reviewed Issue has not been reviewed by Auro team members Type: Feature New Feature labels Sep 10, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed their assignment Sep 11, 2024
@Patrick-Daly-AA Patrick-Daly-AA removed the not-reviewed Issue has not been reviewed by Auro team members label Sep 11, 2024
@Patrick-Daly-AA
Copy link

@michelle-alaskaair to check and ensure there are no design considerations that would like to be taken into consideration for this new feature.

@jason-capsule42 jason-capsule42 removed the Type: Feature New Feature label Oct 3, 2024
fajar-apri-alaska added a commit that referenced this issue Nov 7, 2024
- Add new `disabled` property
- Add css styling for disabled state
- Add aria-disabled attribute
@fajar-apri-alaska fajar-apri-alaska linked a pull request Nov 7, 2024 that will close this issue
6 tasks
@fajar-apri-alaska fajar-apri-alaska linked a pull request Nov 7, 2024 that will close this issue
6 tasks
fajar-apri-alaska added a commit that referenced this issue Dec 13, 2024
- Add new `disabled` property
- Add css styling for disabled state
- Add aria-disabled attribute
fajar-apri-alaska added a commit that referenced this issue Dec 13, 2024
- Add new `disabled` property
- Add css styling for disabled state
- Add aria-disabled attribute
fajar-apri-alaska added a commit that referenced this issue Jan 23, 2025
- Add new `disabled` property for auro-accordion
- Add new `disabled` property for auro-accordion-group
to handle the disabled state of its whole accordion children
- Add css styling for the disabled accordion
- Add aria-disabled attribute as conditional attribute
- Add example and update the documentation for the new feature
- Update the 'aria-expanded' attribute to be as conditional attribute
- Add test for the new feature and 'aria-expanded'-related test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants