Handle nested clickable trigger elements #154
Draft
+749
−448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request addresses an issue where nested clickable elements within an accordion trigger were not handled correctly. The fix ensures that clicks on these nested elements do not interfere with the accordion's toggle behavior. Additionally, the auro-accordion-button component was refactored to extend LitElement instead of AuroButton. Sequence diagram for nested button click handlingsequenceDiagram
actor User
participant NB as Nested Button
participant AB as Accordion Button
participant AC as Accordion Component
User->>NB: clicks nested button
NB->>NB: stopImmediatePropagation()
NB->>NB: stopPropagation()
NB-->>User: handle button click
Note over NB,AB: Event propagation stopped
Note right of AB: Accordion remains unchanged
User->>AB: clicks accordion button
AB->>AC: toggle()
AC->>AC: update expanded state
AC-->>User: show/hide content
Class diagram showing accordion button component changesclassDiagram
class LitElement
class AuroAccordionButton {
+static styles
+static properties
+static register(name)
+render()
}
note for AuroAccordionButton "Changed parent class from AuroButton to LitElement"
LitElement <|-- AuroAccordionButton
class AuroAccordion {
-expanded: boolean
-accordionButton: Element
+firstUpdated()
+toggle()
+render()
}
note for AuroAccordion "Added event listener in firstUpdated"
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
Surge demo deployment failed! 😭 |
apiExamples/nestedButton.html
Outdated
| <auro-accordion id="nestedButtonExample"> | ||
| <span slot="trigger"> | ||
| Click the button for a test | ||
| <button id="nestedButton">Alaska Airlines</button> |
There was a problem hiding this comment.
Our example needs to be an auro-button rather than an HTML5 button.
| button.addEventListener('click', (event) => { | ||
| event.stopImmediatePropagation(); | ||
| event.stopPropagation(); | ||
| console.log('Button clicked'); |
There was a problem hiding this comment.
Suggested change
| console.log('Button clicked'); | |
| console.log('The button in the accordion trigger was clicked. Accordion should not have expanded or collapsed.'); |
src/auro-accordion.js
Outdated
| @@ -142,6 +148,7 @@ export class AuroAccordion extends LitElement { | |||
| * Toggles the visibility of the accordion content. | |||
| */ | |||
| toggle() { | |||
| console.log('button clicked, toggling.......') | |||
There was a problem hiding this comment.
I think we can ditch this console log since it's obvious on the screen that the UI changes.
Comment on lines
+27
to
+45
| // &:after { | ||
| // border-color: transparent; // not supported by tokens - this should never have a color regardless of the theme | ||
| // } | ||
| } | ||
|
|
||
| // .auro-button { | ||
| // all: unset; | ||
| // width: 100%; | ||
| // padding: var(--ds-size-200, $ds-size-200) 0; | ||
|
|
||
| // cursor: pointer; | ||
|
|
||
| // pointer-events: none; | ||
|
|
||
| // &:after { | ||
| // border-color: transparent; // not supported by tokens - this should never have a color regardless of the theme | ||
| // } | ||
| // } | ||
|
|
There was a problem hiding this comment.
Get rid of the commented out code.
| @@ -13,20 +13,36 @@ | |||
| :host { | |||
| border: unset; | |||
|
|
|||
| .auro-button { | |||
| button { | |||
| font: inherit; | |||
There was a problem hiding this comment.
Do we actually need this font rule?
jordanjones243
force-pushed
the
jjones/clickableTriggerItems/#152
branch
from
84b7fc1 to
9e2e342
Compare
jordanjones243
force-pushed
the
jjones/clickableTriggerItems/#152
branch
from
bd41328 to
ffaf7b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alaska Airlines Pull Request
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Resolves: #153
Summary:
Please summarize the scope of the changes you have submitted, what the intent of the work is and anything that describes the before/after state of the project.
Type of change:
Please delete options that are not relevant.
Checklist:
By submitting this Pull Request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Pull Requests will be evaluated by their quality of update and whether it is consistent with the goals and values of this project. Any submission is to be considered a conversation between the submitter and the maintainers of this project and may require changes to your submission.
Thank you for your submission!
-- Auro Design System Team
Summary by Sourcery
New Features: