Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding url_prefix when used as a blueprint on app.register_blueprint #6

Open
Ambro17 opened this issue May 24, 2020 · 1 comment
Labels
good first issue Good for newcomers

Comments

@Ambro17
Copy link
Owner

Ambro17 commented May 24, 2020

It currently breaks redirection as slackify never notices of such event.

Create failing test
Fix it
Check test passes

@Ambro17 Ambro17 changed the title Allow overridinh blueprint url prefix on registering Allow overriding url_prefix when used as a blueprint on app.register_blueprint May 24, 2020
@Ambro17
Copy link
Owner Author

Ambro17 commented Jul 9, 2020

Now that we added support for dependency injection with a custom Blueprint, this fix should be easier. Just add some logic in the overriden register method to detect if the app has registered the blueprint under a different prefix and update it

@Ambro17 Ambro17 added the good first issue Good for newcomers label Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant