Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard access to hour grid #71

Open
AndrewVSutherland opened this issue Aug 23, 2020 · 6 comments
Open

Keyboard access to hour grid #71

AndrewVSutherland opened this issue Aug 23, 2020 · 6 comments

Comments

@AndrewVSutherland
Copy link
Owner

AndrewVSutherland commented Aug 23, 2020

Currently a mouse is necessary to select the hours of availability on student.html because the checkbox grid control does not yet support keyboard access. This is an accessibility issue that needs to be addressed.

A reasonable UI approach would be to set the focus to the upper left checkbox, allow arrows to navigate, and use shift to select (so shift down/up would function like mouse down/up). This would not be hard to implement, just need to decide how to style the selected checkbox (which may be checked or unchecked).

@roed314
Copy link
Collaborator

roed314 commented Aug 26, 2020

What about just showing a light border around it (maybe light blue for contrast with the red)?

@AndrewVSutherland
Copy link
Owner Author

Yeah I think a blurred border might work well. But I'm going to leave this until next week.

@AndrewVSutherland
Copy link
Owner Author

On a related note, the action links on the partner pane currently cannot be activated from the keyboard (they are not focusable). This is easy to fix.

@hanryhu
Copy link

hanryhu commented Aug 31, 2020

I also don't think I was able to select hours from a mobile device. I tapped the squares, but they didn't change.

@AndrewVSutherland
Copy link
Owner Author

AndrewVSutherland commented Aug 31, 2020

@hanryhu Mobille devices are not yet supported (specifically, iOS), see https://psetpartners.mit.edu/faq for a list of currently supported plattforms). We hope to get it working on iOS (so that it works on an iPad) later this week.

@AndrewVSutherland
Copy link
Owner Author

AndrewVSutherland commented Aug 28, 2021

@hanryhu iOS is now supported (since Feb, 2021), as is android (but the site is still optimized for use on a desktop or large tablet -- you can now use it in a browser on a mobile phone, but it is not designed for this).

Keyboard access is still an open issue. No one has actually raised this as an accessibility problem and there are some other changes I'm working on to improve the initial sign-up experience that I think are higher priority, but I will work on this next week if I can find the time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants