Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace fc logging with spdlog #1127

Open
heifner opened this issue May 3, 2023 · 1 comment
Open

Replace fc logging with spdlog #1127

heifner opened this issue May 3, 2023 · 1 comment
Labels
enhancement New feature or request tech debt

Comments

@heifner
Copy link
Member

heifner commented May 3, 2023

This work was started, but not finished in EOSIO/eos#11062

  • fc logging is slow as everything is converted to variant and then to string.
  • fc logging lacks many features of modern logging frameworks: file logging, log rotation, log size limits, logging on differ thread, etc.

Copied over from eosnetworkfoundation/mandel#152

Should re-evaluated it spdlog still the best option. Would also be interesting to see as @spoonincode suggests how the perf of current logging compares to spdlog.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog May 3, 2023
@heifner heifner added enhancement New feature or request tech debt and removed triage labels May 3, 2023
@heifner
Copy link
Member Author

heifner commented May 3, 2023

This may also be useful: https://gist.github.com/heifner/0152ca0859f697a449500a4665664b56

@bhazzard bhazzard mentioned this issue Jun 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request tech debt
Projects
Team Backlog
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heifner @enf-ci-bot