Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IF: make qc_info in instant_finality_extension non-optional #2128

Closed
Tracked by #2110
linh2931 opened this issue Jan 24, 2024 · 0 comments · Fixed by #2145
Closed
Tracked by #2110

IF: make qc_info in instant_finality_extension non-optional #2128

linh2931 opened this issue Jan 24, 2024 · 0 comments · Fixed by #2145
Assignees
@greg7mdp
Labels
👍 lgtm
Milestone
Leap v6.0.0-rc1

Comments

@linh2931
Copy link
Member

From Areg in chat in reviewing #2120

I'm also wondering if we could actually get to the point where the qc_info is never optional.
For example, by leveraging the fact that we can implicitly accept a weak QC claim on the LIB.
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 24, 2024
@greg7mdp greg7mdp moved this from Todo to In Progress in Team Backlog Jan 25, 2024
@greg7mdp greg7mdp added 👍 lgtm and removed triage labels Jan 25, 2024
@greg7mdp greg7mdp added this to the Leap v6.0.0 Cusp milestone Jan 25, 2024
@greg7mdp greg7mdp self-assigned this Jan 25, 2024
@greg7mdp greg7mdp mentioned this issue Jan 26, 2024
Merged
@arhag arhag mentioned this issue Jan 26, 2024
Closed
@greg7mdp greg7mdp linked a pull request Jan 26, 2024 that will close this issue
IF: make qc_info in instant_finality_extension non-optional #2145
Merged
@BenjaminGormanPMP BenjaminGormanPMP moved this from In Progress to Awaiting Review in Team Backlog Jan 30, 2024
@BenjaminGormanPMP BenjaminGormanPMP moved this from Awaiting Review to Done in Team Backlog Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@greg7mdp greg7mdp

Labels
👍 lgtm
Projects
Team Backlog
Archived in project
Milestone
Leap v6.0.0-rc1
Development

Successfully merging a pull request may close this issue.

IF: make qc_info in instant_finality_extension non-optional AntelopeIO/leap
4 participants
@greg7mdp @linh2931 @enf-ci-bot @BenjaminGormanPMP