Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some minor tweaks to cleos output & read only actions #1085

Closed
spoonincode opened this issue Dec 20, 2024 · 1 comment · Fixed by #1120
Closed

some minor tweaks to cleos output & read only actions #1085

spoonincode opened this issue Dec 20, 2024 · 1 comment · Fixed by #1120
Assignees
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team

Comments

@spoonincode
Copy link
Member

For ROtrx I suggest we remove the

warning: transaction executed locally, but may not be confirmed by the network yet

output at the end of cleos. The text is clearly not right for a ROtrx.

I also think we should do something with the 0 us that is always printed, either

  • don't print resource utilization at all (including NET), since it doesn't really matter for ROtrx
  • use populated elapsed for displaying the output here
  • fix nodeos to populate cpu_usage_us for ROtrx? Not sure what to think about that
@heifner
Copy link
Member

heifner commented Dec 20, 2024

  • cpu_usage_us is short for billed_cpu_usage_microseconds, nothing billed here, so probably better to leave that at 0.
  • I like the idea of cleos printing elapsed and not net, since net also implies billed amount.
  • I think we want the JSON output to show no net or cpu_usage_us.

@bhazzard bhazzard added bug The product is not working as was intended. and removed triage labels Jan 16, 2025
@bhazzard bhazzard added this to the Spring v1.1.0-rc1 milestone Jan 16, 2025
@heifner heifner self-assigned this Jan 24, 2025
@heifner heifner added the OCI Work exclusive to OCI team label Jan 24, 2025
@heifner heifner moved this from Todo to In Progress in Team Backlog Jan 24, 2025
heifner added a commit that referenced this issue Jan 24, 2025
…nly trxs. Add elapsed for read-only trxs. Also remove warning of not confirmed for read-only and dry-run trxs.
@heifner heifner moved this from In Progress to Awaiting Review in Team Backlog Jan 24, 2025
heifner added a commit that referenced this issue Jan 25, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Review to Done in Team Backlog Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug The product is not working as was intended. 👍 lgtm OCI Work exclusive to OCI team
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants