Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2P: Experimental implementation of block propagation enhancement proposal #1091

Closed
heifner opened this issue Jan 2, 2025 · 0 comments · Fixed by #1099
Closed

P2P: Experimental implementation of block propagation enhancement proposal #1091

heifner opened this issue Jan 2, 2025 · 0 comments · Fixed by #1099
Assignees
@heifner
Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Milestone
Spring v1.1.0-rc1

Comments

@heifner
Copy link
Member

heifner commented Jan 2, 2025 •
edited
Loading

https://hackmd.io/-766AO7CTjCb99TOAt_jSQ
@heifner heifner mentioned this issue Jan 2, 2025
Closed
@heifner heifner self-assigned this Jan 2, 2025
@heifner heifner added the OCI Work exclusive to OCI team label Jan 2, 2025
@enf-ci-bot enf-ci-bot moved this to Todo in Team Backlog Jan 2, 2025
@heifner heifner added 👍 lgtm and removed triage labels Jan 2, 2025
@heifner heifner added this to the Spring v1.1.0-rc1 milestone Jan 2, 2025
@BenjaminGormanPMP BenjaminGormanPMP moved this from Todo to In Progress in Team Backlog Jan 2, 2025
heifner added a commit that referenced this issue Jan 6, 2025
@heifner
GH-1091 Initial implementation of block_nack with block_nack_message …
b54eea7 
…and block_notice_message
heifner added a commit that referenced this issue Jan 6, 2025
@heifner
GH-1091 Call send_block_nack on correct strand
167ecb4
heifner added a commit that referenced this issue Jan 6, 2025
@heifner
GH-1091 Handle repeated block_notice with request for blocks
5094f92
heifner added a commit that referenced this issue Jan 7, 2025
@heifner
GH-1091 Use correct req_blocks.mode
2afb174
heifner added a commit that referenced this issue Jan 8, 2025
@heifner
GH-1091 Use normal req_blocks.mode since need to start with provided …
1d18678 
…id not id+1
heifner added a commit that referenced this issue Jan 8, 2025
@heifner
GH-1091 Add back sync_write_queue for sync blocks
dd0417b
heifner added a commit that referenced this issue Jan 8, 2025
@heifner
GH-1091 Check if peer has block before sending either block or block_…
f5be27b 
…notice
heifner added a commit that referenced this issue Jan 8, 2025
@heifner
GH-1091 Fix compile error
85bbf2b
heifner added a commit that referenced this issue Jan 8, 2025
@heifner
GH-1091 Handle on_fork with normal request_message correctly
84db166
heifner added a commit that referenced this issue Jan 9, 2025
@heifner
GH-1091 Test threshold of 0
843e3d3
heifner added a commit that referenced this issue Jan 10, 2025
@heifner
GH-1091 Wait for 7 empty blocks before starting perf run. The bios no…
cf44653 
…de is shutdown right before. This allows stabilization if the bios node is the node that most nodes are getting blocks from.
heifner added a commit that referenced this issue Jan 10, 2025
@heifner
GH-1091 Always send block_nack when a block is received the node alre…
7ff8ebf 
…ady has. It may have already echoed back the block, but don't want that to prevent the nack from being sent.
heifner added a commit that referenced this issue Jan 13, 2025
@heifner
GH-1091 Call blk_send_branch directly with requested blocks instead o…
65431db 
…f via last handshake. The last handshake could be very old causing way too many blocks to be sent.
heifner added a commit that referenced this issue Jan 13, 2025
@heifner
GH-1091 Better output on failure
5c0e192
heifner added a commit that referenced this issue Jan 13, 2025
@heifner
GH-1091 Always broadcast blocks we produce
121fadc
heifner added a commit that referenced this issue Jan 13, 2025
@heifner
GH-1091 Only send block_notice if in sync.
35d3118
heifner added a commit that referenced this issue Jan 13, 2025
@heifner
GH-1091 Optimize blk_send_branch for when branch send already in prog…
efd95f6 
…ress
heifner added a commit that referenced this issue Jan 14, 2025
@heifner
GH-1091 Optimize blk_send_branch for when branch send already in prog…
ddcf5df 
…ress
heifner added a commit that referenced this issue Jan 14, 2025
@heifner
GH-1091 Do not request blocks if already requested on a different con…
3627f4c 
…nection
heifner added a commit that referenced this issue Jan 14, 2025
@heifner
GH-1091 Remove is_in_sync check for block notice send. This degrades …
6fcd36a 
…badly.
heifner added a commit that referenced this issue Jan 14, 2025
@heifner
GH-1091 Add p2p-disable-block-nack option
e0cc48b
@heifner heifner mentioned this issue Jan 14, 2025
Merged
heifner added a commit that referenced this issue Jan 14, 2025
@heifner
Merge branch 'main' into GH-1091-block-nack
f4f32eb
@heifner heifner added the enhancement New feature or request label Jan 15, 2025
heifner added a commit that referenced this issue Jan 15, 2025
@heifner
GH-1091 Attempt to make interrupt of trx more common
c9d4276
heifner added a commit that referenced this issue Jan 17, 2025
@heifner
GH-1091 Use contains instead of count
d2ffa9f
heifner added a commit that referenced this issue Jan 17, 2025
@heifner
GH-1091 Remove unneeded code
f414b80
heifner added a commit that referenced this issue Jan 17, 2025
@heifner
GH-1091 Use an enum instead of a bool for to_sync_queue
4e5acfa
heifner added a commit that referenced this issue Jan 17, 2025
@heifner
GH-1091 Updated comment
2cb2f47
heifner added a commit that referenced this issue Jan 17, 2025
@heifner
GH-1091 Simplified if by using the calculated _write_queue_size
9db544e
heifner added a commit that referenced this issue Jan 17, 2025
@heifner
GH-1091 Fix log of received block nack to be clearer
9361c85
heifner added a commit that referenced this issue Jan 17, 2025
@heifner
GH-1091 Update log messages
1a07ac2
heifner added a commit that referenced this issue Jan 20, 2025
@heifner
Merge branch 'main' into GH-1091-block-nack
06dad7d
@bhazzard bhazzard moved this from In Progress to Awaiting Review in Team Backlog Jan 21, 2025
heifner added a commit that referenced this issue Jan 23, 2025
@heifner
GH-1091 Use debug level log instead of info
a1bebf2
heifner added a commit that referenced this issue Jan 24, 2025
@heifner
GH-1091 Improve logic. Make sure it doesn't throw for use on incoming…
a0a621a 
… addresses.
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
Merge remote-tracking branch 'spring/GH-1091-block-nack' into GH-1101-…
a2d6f9e 
…p2p-no-blocks
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
Merge branch 'main' into GH-1091-block-nack
6fbf7b2
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
Merge branch 'GH-1091-block-nack' into GH-1101-p2p-no-blocks
6a0a92b
heifner added a commit that referenced this issue Jan 25, 2025
@heifner
Merge branch 'GH-1091-block-nack' into GH-1101-p2p-no-blocks
ee00bd8
@spoonincode spoonincode moved this from Awaiting Review to Reviewer Approved in Team Backlog Jan 27, 2025
heifner added a commit that referenced this issue Jan 27, 2025
@heifner
Merge pull request #1099 from AntelopeIO/GH-1091-block-nack
f15440e 
P2P: Block propagation optimization
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Team Backlog Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@heifner heifner

Labels
enhancement New feature or request 👍 lgtm OCI Work exclusive to OCI team
Projects
Team Backlog
Status: Done
Milestone
Spring v1.1.0-rc1
Development

Successfully merging a pull request may close this issue.

P2P: Block propagation optimization AntelopeIO/spring
2 participants
@heifner @enf-ci-bot