Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to OpenTelemetry #53

Open
mrsufgi opened this issue Feb 14, 2022 · 5 comments
Open

Migrate to OpenTelemetry #53

mrsufgi opened this issue Feb 14, 2022 · 5 comments
Assignees

Comments

@mrsufgi
Copy link

mrsufgi commented Feb 14, 2022

Hey,

Very cool package, I'm planning to add it to my toolchain but unfortunately you only have openCensus ("deprecated"). Did you ever though about migrating to OpenTelemetry?

LMK, perhaps I can contribute a new tracer.

Best
Ori

@eranharel
Copy link
Contributor

Hi Ori,

I'm glad you find this library useful. While initially we implemented the metrics directly inside the code, we decided to extract it to a separate module github.com/AppsFlyer/go-sundheit/opencensus, and added listeners exactly for that reason. We wanted to allow you to add your own metrics implementation.

So at this point you're welcome to contribute your own OTEL module implementation for go-sundheit (and provide a PR we can merge), implement it internally for your company, or let me know whether you want us to do this (may take a while, as I need to shift priorities for this).

What do you think?

@sagikazarmark
Copy link
Contributor

Keep in mind that submodules is usually better to avoid.

You can always create a separate package, link it in the readme, move it to this org, etc.

@eranharel
Copy link
Contributor

We'll implement this support here: go-sundheit-opentelemetry

@sagikazarmark
Copy link
Contributor

Any news? I can see there is a branch. Any plans to polish/release it?

@eranharel
Copy link
Contributor

Holidays are over in 2 days ;)

I need to review this: AppsFlyer/go-sundheit-opentelemetry#1
Will do it on Tuesday if I have time. You're welcome to take a look too @sagikazarmark

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants