Support for ERC1155

[remiroyc]

Add ERC-1155 Support to NFT Orderbook Smart Contract

Description

We need to extend our NFT orderbook smart contract to support the ERC-1155 standard in addition to the currently supported ERC-721. The current structure of our smart contract is already well-suited for this addition, requiring minimal changes to implement ERC-1155 support.

Current Status

• The smart contract currently supports ERC-721 tokens.
• The existing structure is nearly ready to accommodate ERC-1155.

Tasks

1. Deploy an ERC-1155 token contract on a devnet for testing purposes.
2. Add support for the ERC-1155 standard to the orderbook smart contract:
   • Implement dedicated functions for ERC-1155 interactions.
   • Modify existing logic to handle token quantities (the main difference from ERC-721).

Implementation Details

• The primary change from the current ERC-721 support will be handling token quantities.
• Existing functions and data structures should be reviewed and updated where necessary to account for token quantities.
• New functions specific to ERC-1155 operations may need to be added.

Acceptance Criteria

• ERC-1155 token contract successfully deployed on devnet
• Orderbook smart contract updated to support ERC-1155 tokens
• All existing ERC-721 functionality remains intact
• New ERC-1155 specific functions are implemented and tested
• Quantity handling is correctly implemented for ERC-1155 tokens
• All tests pass, including new tests for ERC-1155 functionality
• PR must be made with the branch https://github.com/ArkProjectNFTs/ark-project/tree/feat/contract-v2 as a base

Additional Notes

• Ensure backwards compatibility with ERC-721 tokens
• Update documentation to reflect new ERC-1155 support
• Consider gas optimization when implementing quantity handling

[manlikeHB]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

Hi, I am Cairo developer with lots of experience contributing to Cairo projects, my OD profile is a witness to this. I've had the experience of extending smart contracts to support and interact with erc20, erc721 or erc-1155, so I believe this is within my comfort zone.

How I plan on tackling this issue

• I will deploy an erc1155 token on testnet
• I will add the support for erc1155 token to the orderbook smart contract by embedding an OZ erc1155 component and ensure it's interface is compatible with the standard erc1155 token.
• Modify existing logic to handle token quantities.
• I will write test covering all edge cases and ensure the new functionality behaves as expected.

[aji70]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

i'm a solidity and cairo smart contract developer with over 2 years experience and belive i have the skill set for the task

[saimeunt]

I am applying to this issue via OnlyDust platform.

My background and how it can be leveraged

I have some experience dealing with ERC721/1155 in Cairo by implementing NFT related ERCs in Cairo:
https://github.com/carbonable-labs/cairo-erc-7496
https://github.com/carbonable-labs/cairo-erc-7498

How I plan on tackling this issue

I will carefully implement the plan described in the issue as it is already very detailed concerning what needs to be done.
I will incrementally develop the feature to match acceptance criteria and make sure all tests pass along the way. I will account for token quantities regarding ERC1155 specificities and take care of gas optimization by trying to leverage batch functions from ERC1155.

[kwiss]

@manlikeHB you are assigned to this issue

[kwiss]

just as a reminder you need to use this branch as a base #440 @manlikeHB

[ptisserand]

Closed by #473