Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage Cabinet crashes watchdog on dedicated server #17

Open
itsdinkd opened this issue Nov 2, 2021 · 4 comments
Open

Storage Cabinet crashes watchdog on dedicated server #17

itsdinkd opened this issue Nov 2, 2021 · 4 comments

Comments

@itsdinkd
Copy link

itsdinkd commented Nov 2, 2021

Player connected Storage Cabinet and Indrev together. Apparently indrev was trying to push multiple different items into storage cabinet, causing a crash.

crash log: https://pastebin.com/myhzXQA0
steps to reproduce

  • hook a cabinet up to an industrial revolution item pipe without setting a whitelist, it tries to send the everything on the network into the cabinet even though it only accepts one type of item, which crashes the serv

Reported on indrev github as well GabrielOlvH/Industrial-Revolution#342

@GabrielOlvH
Copy link

Hi, I'm the IR dev and I see that you look through every tag loaded to find which tags the item has, which is slow. First things first, what is the actual functionality of that? I'm not familiar with the mod so I'm not sure why you need that, just curious.
Looking through every tag, which are a lot in a heavily modded scenario, is slow so you could possibly store a Map<Item, List<Tag/Identifier>> to cache the item and its tags. It would considerably reduce the cpu load when interacting with pipes from other mods

@AshIndigo
Copy link
Owner

Hi! Sorry for the delay on responding, been busy with school and stuff. I've tried to replicate it on my end to no avail, though it's probably just because my computer can tank the poor performance and not trigger the watch dog at all.

I'm more than happy to try and look into improving the performance of that bit of code though

@AshIndigo
Copy link
Owner

@red2blue Do you have a Discord I could potentially contact you on? Would make communication easier to be honest

@itsdinkd
Copy link
Author

https://discord.gg/ZhK2MRs2
diNkd#1337

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants