Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only perform contract code check if non-hardcoded address is used #416

Open
noot opened this issue Apr 25, 2023 · 0 comments
Open

only perform contract code check if non-hardcoded address is used #416

noot opened this issue Apr 25, 2023 · 0 comments
Labels
good first issue Good for newcomers improvement p2 medium priority

Comments

@noot
Copy link
Collaborator

noot commented Apr 25, 2023

as title says, we should only perform the contract code check on startup if the contract used isn't the one hard-coded into our network config. firstly I'm sick of redeploying the sepolia contract each time a comment is changed :p and also release-wise, we can't deploy the mainnet contract each time the contract has a minor update, so master would break if we code-check the hardcoded contract.

@noot noot added improvement p2 medium priority labels Apr 25, 2023
@noot noot added the good first issue Good for newcomers label May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement p2 medium priority
Projects
None yet
Development

No branches or pull requests

1 participant