New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning if swapcli and swapd are on different versions #490

Open

dimalinux opened this issue Jun 21, 2023 · 0 comments

Labels

Collaborator

dimalinux commented Jun 21, 2023

Do we want some kind of warning when swapcli and swapd not the same version?

$ ./bin/swapcli version
swapcli: v0.4.0-go1.20.5
swapd: dev-7619b9a-dirty-go1.20.5
p2p version: /atomic-swap/mainnet/2
env: mainnet
swap creator address: 0x377ed3a60007048DF00135637521170628De89E5

I think that's what other programs do. If someone has a suggestion on what the warning should look like, please add a comment here.

I'd probably just add a line at the end like this:

$ ./bin/swapcli version
swapcli: v0.4.0-go1.20.5
swapd: dev-7619b9a-dirty-go1.20.5
p2p version: /atomic-swap/mainnet/2
env: mainnet
swap creator address: 0x377ed3a60007048DF00135637521170628De89E5

WARNING: client and server versions are different

The text was updated successfully, but these errors were encountered:

dimalinux added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment