Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Task: Remove redux-mock-store in favor of proper, real store #98890

Open
77 tasks
epeicher opened this issue Jan 24, 2025 · 1 comment
Open
77 tasks

Task: Remove redux-mock-store in favor of proper, real store #98890

epeicher opened this issue Jan 24, 2025 · 1 comment
Labels
[Experiment] AI labels added [Feature] API [Feature Group] Developer & Contractor Tools Features and tools designed for developers and contractors working on WordPress.com sites. [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation.

Comments

@epeicher
Copy link
Contributor

epeicher commented Jan 24, 2025 •
edited
Loading

As suggested in this comment, it would be a great idea to get rid of redux-mock-store in favor of real store instances as recommended in the docs.

In principle, it should be straightforward. Also, easy to confirm it works with passing tests.

A quick search reveals that redux-mock-store is used in 77 files so this task can be split into group of tasks:

Click to expand the list of files
  • client/jetpack-cloud/sections/partner-portal/add-stored-credit-card/test/add-stored-credit-card.jsx
  • client/landing/stepper/declarative-flow/internals/steps-repository/design-setup/test/unified-design-picker.tsx
  • client/blocks/jitm/test/index.jsx
  • client/jetpack-cloud/sections/partner-portal/credit-card-fields/test/credit-card-fields.jsx
  • client/jetpack-cloud/sections/partner-portal/credit-card-fields/test/set-as-primary-payment-method.jsx
  • client/jetpack-cloud/sections/partner-portal/credit-card-fields/test/credit-card-submit-button.jsx
  • client/landing/stepper/declarative-flow/internals/steps-repository/site-picker/test/site-picker.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/contact-list/test/contact-list-item.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/contact-list/test/contact-list.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/feature-restriction-badge/test/feature-restriction-badge.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/contact-editor/test/verify-email.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/contact-editor/test/verify-sms.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/contact-editor/test/remove.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/contact-editor/test/index.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/upgrade-link/test/upgrade-link.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/upgrade-popover/test/upgrade-popover.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/upgrade-badge/test/upgrade-badge.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/toggle-activate-monitoring/test/toggle-activate-monitoring.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/notification-settings/test/notification-settings.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/notification-settings/form-content/test/email-notification.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/notification-settings/form-content/test/mobile-push-notification.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/notification-settings/form-content/test/sms-notification.tsx
  • client/jetpack-cloud/sections/agency-dashboard/downtime-monitoring/notification-settings/form-content/test/notification-duration.tsx
  • client/components/data/query-jetpack-modules/test/query-jetpack-modules.jsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-expanded-content/test/boost-site-performance.test.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-expanded-content/test/monitor-activity.test.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-expanded-content/test/backup-storage.test.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/test/site-error-content.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/test/sites-overview.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-table-row/test/site-table-row.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-table/test/site-table.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-content/test/site-content.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-actions/test/site-actions.tsx
  • client/jetpack-cloud/sections/agency-dashboard/sites-overview/site-card/test/site-card.tsx
  • client/blocks/reader-site-subscription/test/index.tsx
  • client/blocks/app-banner/test/app-banner.jsx
  • client/mocks/storybook/redux.tsx
  • client/components/jetpack/upsell-product-card/test/index.jsx
  • client/controller/test/controller.js
  • client/my-sites/plugins/plugin-management-v2/hooks/test/use-plugin-version-info.tsx
  • client/components/domains/domain-upsell-callout/test/index.js
  • client/my-sites/plugins/plugin-management-v2/test/update-plugin.test.tsx
  • client/my-sites/plugins/plugin-management-v2/test/plugin-manage-connection.test.tsx
  • client/my-sites/plugins/plugin-management-v2/test/remove-plugin.test.tsx
  • client/my-sites/plugins/plugin-management-v2/test/plugin-common-card.test.tsx
  • client/sites/components/test/sites-dashboard-banners-manager.test.tsx
  • client/my-sites/plugins/plugin-management-v2/test/plugin-action-status.test.tsx
  • client/my-sites/plugins/plugin-management-v2/test/plugin-common-table.test.tsx
  • client/sites/tools/deployments/deployments/test/deployments-list-item-actions.test.tsx
  • client/hosting/server-settings/components/defensive-mode-card/test/card.tsx
  • client/signup/steps/emails/test/index.tsx
  • client/hosting/server-settings/components/cache-card/test/index.tsx
  • client/hosting/server-settings/components/sftp-card/test/index.js
  • client/hosting/server-settings/test/index.js
  • client/hosting/server-settings/test/hosting-activate-status.jsx
  • client/me/domain-upsell/test/index.jsx
  • client/sites/tools/monitoring/test/main.js
  • client/sites/tools/staging-site/components/staging-site-card/test/index.js
  • client/sites/tools/staging-site/test/index.js
  • client/components/activity-card/toolbar/test/actions-button.jsx
  • client/sites/settings/administration/tools/delete-site/test/index.js
  • client/my-sites/test/controller.js
  • client/lib/promote-post/test/index.jsx
  • client/my-sites/domains/domain-management/domain-overview-pane/test/index.test.tsx
  • client/my-sites/domains/domain-management/test/controller.test.tsx
  • client/my-sites/domains/domain-management/components/primary-domain-selector/test/index.tsx
  • client/my-sites/domains/domain-management/subpage-wrapper/test/index.test.tsx
  • client/my-sites/subscribers/components/subscriber-list/test/subscriber-row.test.tsx
  • client/my-sites/promote-post-i2/components/blaze-page-view-tracker/test/index.jsx
  • client/my-sites/checkout/test/utils.js
  • client/my-sites/checkout/checkout-thank-you/marketplace/test/marketplace-thank-you-plugin-section.jsx
  • client/my-sites/checkout/test/controller.js
  • client/my-sites/subscribers/components/subscriber-profile/test/subscriber-profile.test.tsx
  • client/my-sites/site-indicator/test/index.js
  • client/my-sites/checkout/checkout-thank-you/test/index.js
  • client/my-sites/customer-home/cards/features/domain-upsell/test/index.jsx
  • client/my-sites/customer-home/cards/tasks/domain-upsell/test/index.jsx
@github-actions github-actions bot added the [Feature Group] Developer & Contractor Tools Features and tools designed for developers and contractors working on WordPress.com sites. label Jan 24, 2025
@github-actions GitHub Actions
Copy link

OpenAI suggested the following labels for this issue:

  • [Feature Group] Developer & Contractor Tools: The issue is related to the technical implementation of the Redux store, which is important for developers working on the codebase.
  • [Feature] Plugins: The task involves changing how testing is done in the application, which relates to plugin development and maintenance.
  • [Feature] API: Removing the redux-mock-store indicates an alteration in how API interactions might be handled in tests.

@github-actions github-actions bot added [Feature] API [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation. [Experiment] AI labels added labels Jan 24, 2025
@epeicher epeicher mentioned this issue Jan 24, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Experiment] AI labels added [Feature] API [Feature Group] Developer & Contractor Tools Features and tools designed for developers and contractors working on WordPress.com sites. [Feature] Plugins Features related to plugins on WordPress.com, including search, management, and installation.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@epeicher