Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tests #11

Open
s-pic opened this issue Mar 15, 2021 · 1 comment
Open

unit tests #11

s-pic opened this issue Mar 15, 2021 · 1 comment
Labels
question Further information is requested

Comments

@s-pic
Copy link

s-pic commented Mar 15, 2021

Hi! I integrated useHasOverflow in our TSX app and it helped me a lot, so first of all thanks for that.
Now I will have to write tests for it since we want all used code to be test-covered, which also goes for dependencies.
I would like to give back to this repo and submit the test code.

So my questions are:

  • are you open for a PR here?
  • are you planning to add a testing setup any time soon? Prep work here would keep the scope of that eventual PR as small as possible
@s-pic s-pic added the question Further information is requested label Mar 15, 2021
@steabert
Copy link
Member

steabert commented Aug 18, 2022

We are definitely open to PRs!

We're not currently working on adding a test setup here, but would be interested if someone wants to work on that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants