Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AVM Module Issue]: The database-account module does not allow selecting which SQL role to associate the principal IDs with. #4381

Open
1 task done
mirabellog opened this issue Feb 4, 2025 · 2 comments
Assignees
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working

Comments

@mirabellog
Copy link

Check for previous/existing GitHub issues

  • I have checked for previous/existing GitHub issues

Issue Type?

Bug

Module Name

avm/res/document-db/database-account

(Optional) Module Version

No response

Description

This module contains two parameters: sqlRoleDefinitions, which is used to deploy SQL role definitions, and sqlRoleAssignmentsPrincipalIds, which holds the principalIds for role assignments. Currently, all principalIds will be assigned the roles defined in the other parameter. My recommendation is to move sqlRoleAssignmentsPrincipalIds inside the sqlRoleDefinitions type so that it is possible to select which user to assign roles to.
My recommendation is to do something like this:

(Optional) Correlation Id

No response

@mirabellog mirabellog added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Feb 4, 2025

Important

The "Needs: Triage 🔍" label must be removed once the triage process is complete!

Tip

For additional guidance on how to triage this issue/PR, see the BRM Issue Triage documentation.

@microsoft-github-policy-service microsoft-github-policy-service bot added the Type: Bug 🐛 Something isn't working label Feb 4, 2025
@avm-team-linter avm-team-linter bot added the Class: Resource Module 📦 This is a resource module label Feb 4, 2025
@github-project-automation github-project-automation bot moved this to Needs: Triage in AVM - Module Issues Feb 4, 2025
Copy link

@mirabellog, thanks for submitting this issue for the avm/res/document-db/database-account module!

Important

A member of the @Azure/avm-res-documentdb-databaseaccount-module-owners-bicep or @Azure/avm-res-documentdb-databaseaccount-module-contributors-bicep team will review it soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue Type: Bug 🐛 Something isn't working
Projects
Status: Needs: Triage
Development

No branches or pull requests

2 participants