Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename packets to messages #81

Open
carlbennett opened this issue Mar 2, 2018 · 2 comments
Open

Rename packets to messages #81

carlbennett opened this issue Mar 2, 2018 · 2 comments
Labels
bnetdocs-phoenix documentation enhancement question

Comments

@carlbennett
Copy link
Member

May warrant some discussion.
@Davnit
Copy link
Member

Davnit commented Mar 12, 2018

I'm relatively indifferent to this. I still think of messages as "packets" and "packets" as payloads/fragments. I think a lot of older/existing code (outside of this project) refers to messages as packets as well... but the naming isn't really that important, IMO.

@nmbook
Copy link
Member

nmbook commented Mar 12, 2018

I used "messages" when documenting BotNet on here, if you guys want an example. I think it's fine to leave it one way or the other.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bnetdocs-phoenix documentation enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@carlbennett @nmbook @Davnit