Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be at least a test with a material different from 'PbrMaterial' #372

Open
setzer22 opened this issue Feb 25, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed module: core Core issues with the renderer or interface module: routines Issues with the render routines

Comments

@setzer22
Copy link
Contributor

setzer22 commented Feb 25, 2022

To ensure custom workflows are covered by the test suite to some extent, the tests should be using something other than PbrMaterial. This way issues like #371 can be caught earlier on.

Something like a test scene creating a custom material type with a simple shader, then adding a few objects using that material.

@cwfitzgerald
Copy link
Member

An example would be good also to show off what you have to do as a user, we should also split out unlit materials from the pbr material as that way they can get a much lighter shader.

@cwfitzgerald cwfitzgerald added enhancement New feature or request help wanted Extra attention is needed module: core Core issues with the renderer or interface module: routines Issues with the render routines labels Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed module: core Core issues with the renderer or interface module: routines Issues with the render routines
Projects
None yet
Development

No branches or pull requests

2 participants