Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile Error example 10 #3

Open
vikkio88 opened this issue May 29, 2020 · 4 comments
Open

Compile Error example 10 #3

vikkio88 opened this issue May 29, 2020 · 4 comments

Comments

@vikkio88
Copy link

Hi there, while trying to compile example 10 on sdl I am getting an error

$ cd 10_heaps_load_model 
$ haxe game.hxml              
Game.hx:26: characters 19-37 : Type not found : h3d.scene.DirLight

weirdly enough in the main doc here the link to the source code is broken like it is not there anymore https://github.com/HeapsIO/heaps/blob/master/h3d/scene/DirLight.hx

@vikkio88
Copy link
Author

unfortunately does the same on example 11

[~/ndd/heaps-examples/11_heaps_shader3d] [master *]
-> % haxe game.hxml && hl game.hl
Game.hx:51: characters 19-37 : Type not found : h3d.scene.DirLight

@vikkio88
Copy link
Author

vikkio88 commented May 30, 2020

found the issue, I am using heaps1.8.0 and they changed namespace, will open a PR

Hey,

I believe in a recent change in Heaps, rendering Classes have been split into two types: “fwd” (forward rendering) and “pbr” (physically based rendering) and the old Classes like DirLight have been put into the respective pbr/fwd subfolder.
I think “fwd” is the equivalent to the old default rendering. So instead of h3d.scene.DirLight it should now be:

var light = h3d.scene.fwd.DirLight(...

(note the added “.fwd” in there)

The examples haven’t been updated yet, that’s why they still point to the wrong folder.

Hope this helps :^) I ran into the same problem recen

from here

@jerrygreen
Copy link

jerrygreen commented Nov 4, 2020

Unfortunately the author didn't specify versions he used (haxe, heaps, and in some examples other libs are used, with who knows what versions), so after half a year the examples won't work with the modern versions ofc. A lot of work, but useless. Shame...

@vikkio88
Copy link
Author

vikkio88 commented Nov 4, 2020

@jerrygreen I had also done a PR to fix that, but it's still there.
if you are interested though I adopted this codebase, rebased and translated all examples to English from Russian: https://github.com/nientedidecente/heaps-examples

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants