Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetChallengerLeagueAsync has incorrect modal #623

Closed
lian-ders opened this issue Apr 26, 2019 · 2 comments · Fixed by #622
Closed

GetChallengerLeagueAsync has incorrect modal #623

lian-ders opened this issue Apr 26, 2019 · 2 comments · Fixed by #622
Labels
bug

Comments

@lian-ders
Copy link

When im calling await api.League.GetChallengerLeagueAsync(Region.Euw, Queue.RankedSolo5x5); the enties modal looks like this:

image

As you can see leagueName is null for all entries. I think this is because the Riot api defines this property as summonerName and also summonerId, which is missing. Changing the region or queue doen't change the result.

I think that this might be a bug since the LeaguePosition model doesn't corresponds with the RiotApi model.
@kirides
Copy link
Contributor

kirides commented Apr 28, 2019 •
edited
Loading

this will be fixed with merging #622

@kirides kirides mentioned this issue Apr 28, 2019
Merged
@JanOuborny JanOuborny added the bug label May 1, 2019
@kwiatkos0
Copy link

Fixed with #627

BenFradet pushed a commit that referenced this issue May 11, 2019
@kirides @BenFradet
Adjust league, fixes #619, #621 and #623
4712f8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjust league (Fixes #619, #621 & #623)
4 participants
@lian-ders @JanOuborny @kirides @kwiatkos0