Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better formatting for purchase cost. #143

Open
2 tasks done
johncsuti opened this issue Jan 18, 2025 · 4 comments
Open
2 tasks done

Better formatting for purchase cost. #143

johncsuti opened this issue Jan 18, 2025 · 4 comments
Assignees
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.

Comments

@johncsuti
Copy link
Contributor

Is your feature request related to a problem?

Better formatting for cobblestone generator purchase cost. Currently it shows 10E7 for 10 Million or 1000000 for 1 Million.

Describe the solution you'd like.

We should have it show either $10 Million, $10M or something similar if using a random number like 10,987,654.21 We should format it with commas and a . for cents.

Describe alternatives you've considered.

None

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

No response

@johncsuti
Copy link
Contributor Author

Image

Image

@tastybento tastybento self-assigned this Jan 19, 2025
@tastybento tastybento added the Status: Under investigation Investigating the interest and the feasability of the issue. label Jan 19, 2025
@tastybento
Copy link
Member

@tastybento
Copy link
Member

Formatting is by Locale, so example outputs:

Locale Expected Output
US 10,000,000.25
UK 10,000,000.25
France 10 000 000,25
China 10,000,000.25
Germany 10.000.000,25
Japan 10,000,000.25

Key Notes
• The thousand separator and decimal separator vary across locales:
• US/UK/China/Japan: Use commas for thousands and periods for decimals.
• France/Germany: Use spaces or periods for thousands and commas for decimals.

@johncsuti
Copy link
Contributor Author

Sorry ill give it a show when i can. im currently about to leave the house.

@tastybento tastybento added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Under investigation Investigating the interest and the feasability of the issue. labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Done This issue has been completed or answered. This pull request has been merged.
Projects
None yet
Development

No branches or pull requests

2 participants