Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filepath in HDF5ArraySeed's validity method be extracted with path()? #32

Open
LTLA opened this issue Sep 4, 2020 · 1 comment
Open

Comments

@LTLA
Copy link

LTLA commented Sep 4, 2020

We're creating a Seed class that inherits from HDF5ArraySeed but overwrites path() to dynamically point to resources at different realized filepaths; a similar solution to that in #20 but for our internal datasets.

It almost works, but we need to hack around the validity method in HDF5ArraySeed so that it doesn't actually try to look up the file in @filepath (which is only guaranteed to exist when calling path(), via our internal caching mechanism).

It might be possible to use path() in the validity method, and then everything would just work off the bat.

@LTLA
Copy link
Author

LTLA commented Jan 28, 2021

Also, if extensions of this nature are supported, we should stress that any methods for path() must return a normalized or path.expand()ed path. Got hit by rappdirs updates that started reporting ~ in the path and h5mread didn't like it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant