Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hex/getHex issue with value 12a05f200 (5e9) #98

Open
olegabr opened this issue Nov 22, 2022 · 0 comments
Open

hex/getHex issue with value 12a05f200 (5e9) #98

olegabr opened this issue Nov 22, 2022 · 0 comments

Comments

@olegabr
Copy link

olegabr commented Nov 22, 2022

An additional zero is added after hex/getHex operations applied.
I've checked and it looks like it is pack/unpack behavior for the 'H*' format.

The commit with a test to demonstrate the issue: olegabr@56d7bb3

$ ./vendor/bin/phpunit 
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

Error:         No code coverage driver is available

........F......................................................  63 / 196 ( 32%)
............................................................... 126 / 196 ( 64%)
............................................................... 189 / 196 ( 96%)
.......                                                         196 / 196 (100%)

Time: 40 ms, Memory: 6.00MB

There was 1 failure:

1) BitWasp\Buffertools\Tests\BufferTest::testSerialize2
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'12a05f200'
+'12a05f2000'

buffertools-php/tests/BufferTest.php:106

FAILURES!
Tests: 196, Assertions: 592, Failures: 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant