Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Refactor Contract class to make it usable outside of out-of-the-box protocols #18

Open
andreujuanc opened this issue Jan 24, 2021 · 0 comments

Comments

@andreujuanc
Copy link

Hi,

I'm about to start experimenting with this library, but I saw that the Contract class is "blocked" from being extended properly.
My proposal would be to change the constructor https://github.com/BitGo/eth-contracts/blob/master/src/contract/index.ts#L77 to be proper, and have other alternatives to read from the file system.
Even just an overload would be sufficient.
My use case is that I might want to use that class for a built-in protocol (Compound for example) but also to use a custom one that would make no sense to integrate into this library as a PR.

Best,

JC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant