Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add Cryptographic Signatures for all releases #82

Open
maltfield opened this issue Apr 25, 2024 · 4 comments
Open

[FR] Add Cryptographic Signatures for all releases #82

maltfield opened this issue Apr 25, 2024 · 4 comments
Labels
feature-request New feature or request

Comments

@maltfield
Copy link

Describe the feature

Description

Currently it is not possible to verify the authenticity or cryptographic integrity of the downloads from sourceforge.net (or seemingly any other domain) because the releases are not cryptographically signed.

This makes it hard for BlissOS users to safely obtain BlissOS, and it introduces them to watering hole attacks.

Steps to Reproduce

  1. Go to the https://blissos.org
  2. Click the big blue Download button in the top-right of the header
  3. Search the page for "verify" or "signature" or "gpg" or "pgp"
  4. ???
  5. Get confused and open ticket

Expected behavior: [What you expected to happen]

A few things are expected:

  1. I should be able to download the BlissOS PGP key out-of-band from popular third-party keyservers (eg https://keys.openpgp.org/)
  2. I should be able to download a cryptographic signature of the release (or, better, the releases' digest file, such as a SHA256SUMS.asc file) along with the release itself
  3. The downloads page itself should include a link to the documentation page that describes how to do the above two steps

Actual behavior: [What actually happened]

There's just literally no information on verifying downloads, and it appears that it is not possible to do so.

Links to commits (if applicable)

No response

Additional information or screenshots

No response

@maltfield maltfield added the feature-request New feature or request label Apr 25, 2024
@electrikjesus
Copy link
Member

We provide sha256 sum files:
Screenshot_20240425-162213_Chrome

And Sourceforge provides these hashes as well:
Screenshot_20240425-162228_Chrome

@maltfield
Copy link
Author

I see that some BlissOS releases have a cooresponding .sha file.

That file is empty but, regardless, hashes do not provide security, unless those hashes are cryptographic hash functions (eg not sha1) and those are signed. Hashes without signatures protect against download corruption; they do not provide any security.

An example attack that would be protected by signatures is a publishing infrastructure compromise. Remember: monero's release infrastructure has already been comprimised once. And here's a great list of historically relevant cases where this happened:

@maltfield
Copy link
Author

maltfield commented Apr 25, 2024

@electrikjesus this ticket is to address security (authenticity), not corruption (integrity).

@maltfield
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants