Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

代表林间有风团队表达崇高的敬意! #1

Open
pedrogao opened this issue Nov 24, 2019 · 2 comments
Open

代表林间有风团队表达崇高的敬意! #1

pedrogao opened this issue Nov 24, 2019 · 2 comments

Comments

@pedrogao
Copy link

刚看了一下仓库的整体代码以及线上demo,整体来说还是相当不错的,这不是一个小项目,确实付出了比较多的时间。
.jsx里面的三目运算符使用的还不甚合理,记得优化一下,其它的结构几乎与vue版本无异,几乎也实现了全部功能,可见作者着实用心,让人感佩。
当然react的新特性hooks我还未看到,作者可以适当使用一下,毕竟新特性的噱头,很多人都愿意买单的,无论是为了作者自己的推广,还是学习规划。
另外redux的使用有些许臃肿,可以再适当拆分,当然如果使用mobx必然会更棒,redux的概念有时候很不友好,让人生畏。
最后,希望作者再接再厉,早日成为团队推荐react实现。

@Bongkai
Copy link
Owner

Bongkai commented Nov 24, 2019 via email

@RekcuFrehtom
Copy link

好!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants