Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Predicates: inconsistent docs & code regarding isProperty & isLiteral #74

Open
steveschmitt opened this issue Feb 14, 2023 · 0 comments
Assignees

Comments

@steveschmitt
Copy link
Member

steveschmitt commented Feb 14, 2023

This is about how to tell Breeze whether the object of a Predicate is a property name or a literal.

The Query using JSON doc says use the isProperty flag.

The Querying in depth doc says use the isLiteral flag.

The code comments in predicate.ts 77 says to use isLiteral.

The actual code in predicate.ts 937 says to use isProperty.

We need to change it to isProperty everywhere, I think, but we need to find out why we thought it was isLiteral at one point. Did this change from Breeze 1.x to 2.x?

Related to #73.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants