Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using units library for variables #230

Open
DanPeled opened this issue Sep 20, 2024 · 4 comments
Open

Using units library for variables #230

DanPeled opened this issue Sep 20, 2024 · 4 comments
Labels
wontfix This will not be worked on

Comments

@DanPeled
Copy link

DanPeled commented Sep 20, 2024

Using the units library avoid adding comments like in meters per second, because u can automatically convert it from whatever measure it was passed as and makes it more clear to users

Ill probably PR that

@thenetworkgrinch
Copy link
Contributor

Due to the nature of Java units I wont be adding this until the new robot controller comes out.

@thenetworkgrinch thenetworkgrinch added the wontfix This will not be worked on label Nov 18, 2024
@DanPeled
Copy link
Author

Makes sense , let's just hope we keep using wpilib

@thenetworkgrinch
Copy link
Contributor

They have already committed and required the new company to work with WPILib in the RFP fortunately so that wont be an issue :)

@DanPeled
Copy link
Author

Thats great, means less re-learning for so many teams

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants