Skip to content
This repository has been archived by the owner on Jun 16, 2021. It is now read-only.

Separate each test run artifacts from each other #28

Open
zelzhan opened this issue Aug 31, 2020 · 2 comments
Open

Separate each test run artifacts from each other #28

zelzhan opened this issue Aug 31, 2020 · 2 comments
Labels

Comments

@zelzhan
Copy link
Collaborator

zelzhan commented Aug 31, 2020

Right now github interactions api downloads the artifact to the bucket. But the problem is that VM uses the artifact on the bucket. But what will happen if another VM will be created and github-interactions-api will download artifact? It will override the existing one.

Therefore my suggestion is, to change the path in which the artifact is downloaded according to the identificatior of the test-run. For example, artifact will be downloaded to the following path /bucket/ea28s1804712e/ccextractor. Also, it is important to specify path to the ccextractor associated with the identificator of the test-run.

Also, github-interactions-api service should be called from the orchesetration library for each test run.

@zelzhan
Copy link
Collaborator Author

zelzhan commented Sep 6, 2020

You have to put placeholder to the script.sh file. Before sending the script to the VM, you have to parse the file and replace the placeholder with the id of the test-run. Location: libs/api-implementation/orchestration/.../orchestration.service.ts

@zelzhan
Copy link
Collaborator Author

zelzhan commented Sep 6, 2020

Also, in order to call github-interactions-api for each test run, you have to call the url of the github-interactions-api to download the latest artifact. One should create new service in libs/api-implementation/orchestration/services/ and call the github-interactions-api endpoint.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant