Deprecate PdiEvent::and_with

[tpadioleau]

We have both PdiEvent::with and PdiEvent::and_with. I am not convined of the benefit in practice as it is still readable to chain with calls

PdiEvent("event")
    .with("data1", data1)
    .with("data2", data2);

I strongly suggest we keep a single version.

[tpadioleau]

@EmilyBourne any opinion on this ?

[EmilyBourne]

I would tend to agree with you. I don't see a reason to have 2 methods that do the same thing.

In Gyselalib++ we are using:
https://github.com/gyselax/gyselalibxx/blob/86d95abd5672362c600714d6cb4c5abbd0dc9c7c/src/geometryXYVxVy/time_integration/predcorr.cpp#L58-L62

but probably we are just copying across whatever was done the first time.