GrammaticalExpression _len_ does not return number of atoms / leaf nodes

[nathimel]

The len method for GrammaticalExpression returns the total number of nodes, but we typically report 'number of atoms' for complexity.

https://github.com/CLMBRs/ultk/blob/generic-meaning/src/ultk/language/grammar.py#L182

So having some way of getting just the leaf nodes would be good.

[shanest]

Agreed! I kind of think __len__ should stay as it is, but we can easily add something like count_atoms. Do you think it should be a method in GrammaticalExpression or independent?

[nathimel]

Maybe a helper method in grammar.py is a compromise?

On Wed, Jun 5, 2024 at 2:23 PM Shane Steinert-Threlkeld < ***@***.***> wrote: Agreed! I kind of think __len__ should stay as it is, but we can easily add something like count_atoms. Do you think it should be a method in GrammaticalExpression or independent? — Reply to this email directly, view it on GitHub <https://urldefense.com/v3/__https://github.com/CLMBRs/ultk/issues/42*issuecomment-2150986203__;Iw!!CzAuKJ42GuquVTTmVmPViYEvSg!JGkUxPHyHYJMP34GhhQBjQuWOapVcz6BZfMbDkWx757VAljgv-xxsA9_Aaf_2k15OJe5BOHGwJ6kbshxbbTxQw$>, or unsubscribe <https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/AQRRJKOL2MXHPPDX5NMSG5TZF56UVAVCNFSM6AAAAABIUX2MISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQHE4DMMRQGM__;!!CzAuKJ42GuquVTTmVmPViYEvSg!JGkUxPHyHYJMP34GhhQBjQuWOapVcz6BZfMbDkWx757VAljgv-xxsA9_Aaf_2k15OJe5BOHGwJ6kbsjhvG2Zew$> . You are receiving this because you authored the thread.Message ID: ***@***.***>

-- Nathaniel Imel Ph.D. Student, Department of Language Science University of California, Irvine nathimel.github.io